Skip to content

Fix annotation package #3716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 2, 2025
Merged

Fix annotation package #3716

merged 5 commits into from
Jul 2, 2025

Conversation

ngocnhan-tran1996
Copy link
Contributor

No description provided.

@ngocnhan-tran1996
Correct NonNull annotation package
1473cd8 
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@ngocnhan-tran1996
Correct Nullable annotation package
aee1459 
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@ngocnhan-tran1996
Replace jetbrains NotNull
e0f041e 
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@ngocnhan-tran1996
Update copyright headers
c20b7b3 
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@sobychacko
Copy link
Contributor

@ngocnhan-tran1996 You need to add the package-info.java file to those packages and include the packages there. Ensure that NonNullApi remains the default. Once you do that, we won't need the explicit NonNull annotation in those modified classes, as that is the default.

@ngocnhan-tran1996
Add package-info
8bede16 
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@ngocnhan-tran1996 ngocnhan-tran1996 force-pushed the fix-annotation-package branch from 1444c44 to 8bede16 Compare July 2, 2025 17:08
@ngocnhan-tran1996
Copy link
Contributor Author

@sobychacko

I've updated package-info.java.

@sobychacko sobychacko added this to the 1.1.x milestone Jul 2, 2025
@sobychacko sobychacko merged commit 2122c65 into spring-projects:main Jul 2, 2025
2 checks passed
spring-builds pushed a commit that referenced this pull request Jul 2, 2025
@ngocnhan-tran1996 @spring-builds
Fix annotation package (#3716)
3a18724 
Fixes #3716

* Correct NonNull annotation package
* Correct Nullable annotation package
* Replace jetbrains NotNull
* Update copyright headers
* Add package-info

Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
(cherry picked from commit 2122c65)
@spring-builds spring-builds mentioned this pull request Jul 2, 2025
Closed
@ngocnhan-tran1996 ngocnhan-tran1996 deleted the fix-annotation-package branch July 3, 2025 03:20
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
@ngocnhan-tran1996 @scionaltera
Fix annotation package (spring-projects#3716)
3e7542d 
Fixes spring-projects#3716

Auto-cherry-pick to 1.0.x

* Correct NonNull annotation package
* Correct Nullable annotation package
* Replace jetbrains NotNull
* Update copyright headers
* Add package-info

Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
@ngocnhan-tran1996 @chedim
Fix annotation package (spring-projects#3716)
3922a15 
Fixes spring-projects#3716

Auto-cherry-pick to 1.0.x

* Correct NonNull annotation package
* Correct Nullable annotation package
* Replace jetbrains NotNull
* Update copyright headers
* Add package-info

Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code cleanup for: backport-to-1.0.x status: backported
Projects
None yet
Milestone
1.1.0.M1
Development

Successfully merging this pull request may close these issues.
3 participants
@ngocnhan-tran1996 @sobychacko @spring-builds