refactor: Restructure MCP server auto-configuration modules for better modularity #4196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r modularity This commit reorganizes the Spring AI MCP (Model Context Protocol) server auto-configuration modules to improve separation of concerns and modularity: **Module Restructuring:** - Rename spring-ai-autoconfigure-mcp-server → spring-ai-autoconfigure-mcp-server-common , spring-ai-autoconfigure-mcp-server-sse - Rename spring-ai-autoconfigure-mcp-streamable-server-* → spring-ai-autoconfigure-mcp-server-streamable-* - Rename spring-ai-autoconfigure-mcp-stateless-server-* → spring-ai-autoconfigure-mcp-server-stateless-* **New Common Modules:** - Extract spring-ai-autoconfigure-mcp-server-properties for shared configuration properties - Create spring-ai-autoconfigure-mcp-server-common for shared auto-configuration logic between STDIO, SSE and Streamable-HTTP servers **Key Changes:** - Move McpServerProperties and related properties classes to dedicated properties module shared with all server modules. - Extract McpServerChangeNotificationProperties and McpServerStreamableHttpProperties - Refactor auto-configuration classes to use common base configurations - Update package names from *.autoconfigure to *.common.autoconfigure.properties - Consolidate tool callback converter logic into common module **Configuration Updates:** - Separate SSE-specific properties from general server properties - Improve conditional configuration with new condition classes - Update dependency references across all affected modules and starters - Maintain backward compatibility for existing property configurations **Impact:** - Better separation between different MCP server transport mechanisms (SSE, Streamable HTTP, Stateless) - Reduced code duplication across auto-configuration modules - Cleaner dependency management and module boundaries - Improved maintainability and extensibility for future MCP server features All existing functionality is preserved while providing a more modular and maintainable architecture for MCP server auto-configuration. Co-authored-by: yinh <yinh@133.cn>
tzolov
force-pushed
the
improve-mcp-streamable-auto-configuration
branch
from
3aca3ae to
d3fec94
Compare
Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
markpollack
reviewed
Aug 21, 2025
| |=== | ||
|
|
||
| === Stateless Connection Properties | ||
|
|
||
| All connection properties are prefixed with `spring.ai.mcp.server.streamable-http`: |
There was a problem hiding this comment.
this should be server.stateless?
|
merged in a38aad8 |
|
@markpollack , this merge seems messed up. It containing code not related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reorganizes the Spring AI MCP (Model Context Protocol) server auto-configuration modules to improve separation of concerns and modularity:
Module Restructuring:
New Common Modules:
Key Changes:
Configuration Updates:
Impact:
All existing functionality is preserved while providing a more modular and maintainable architecture for MCP server auto-configuration.
Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:
git commit -s) per the DCOmainbranch and squash your commitsFor more details, please check the contributor guide.
Thank you upfront!