-
Notifications
You must be signed in to change notification settings - Fork 1.9k
bedrock #4365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
bedrock #4365
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,6 +65,8 @@ To clone it you have to either: | |
|
||
## Building | ||
|
||
You'll have the best luck compiling against Java 17. | ||
|
||
To build with running unit tests | ||
|
||
```shell | ||
|
@@ -101,9 +103,10 @@ A full integration test is done twice a day in the [Spring AI Integration Test R | |
One way to run integration tests on part of the code is to first do a quick compile and install of the project | ||
|
||
```shell | ||
./mvnw clean install -DskipTests -Dmaven.javadoc.skip=true | ||
./mvnw -DskipTests -Dmaven.javadoc.skip=true -Ddisable.checks=true spring-javaformat:apply clean install | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. adding 'disable.checks' just shifts the checksytyle fixes to the person who merges the PR, so can't exclude it. |
||
``` | ||
Then run the integration test for a specific module using the `-pl` option | ||
|
||
```shell | ||
./mvnw verify -Pintegration-tests -pl spring-ai-spring-boot-testcontainers | ||
``` | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will state simply, build using java 17