Skip to content

Conversation

chemicL
Copy link
Member

@chemicL chemicL commented Oct 6, 2025

Without this change, a ChatClient instance would be configured without the MCP capabilities expressed via mcp-annotations.

This surfaces when client-side MCP features are added such as elicitation, sampling, or logging.

…iguration

Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
@chemicL chemicL added this to the 1.1.0.M4 milestone Oct 6, 2025
@chemicL chemicL added the MCP label Oct 6, 2025
@ilayaperumalg
Copy link
Member

LGTM

@tzolov
Copy link
Contributor

tzolov commented Oct 6, 2025

I've added this IT related to the issue: #4554
While ensuring the auto-confg order is important it won't help ensuring the bean postprocessor order.
The #4554 will fail if we use @lazy ChatClient instead of ObjectProvider<ChatClient.Builder> even with this order fix.

@tzolov tzolov merged commit bb65f1a into spring-projects:main Oct 6, 2025
2 checks passed
@chemicL chemicL deleted the autoconfig-order-for-mcp-client-tools branch October 6, 2025 14:38
Willam2004 pushed a commit to Willam2004/spring-ai that referenced this pull request Oct 11, 2025
…iguration (spring-projects#4553)

Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
Signed-off-by: 家娃 <guanjing.pangj@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants