-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Closed
Labels
api: breaking-changeIssues that require or introduce an API breaking changeIssues that require or introduce an API breaking changein: corein: infrastructurein: integrationin: teststatus: for-internal-teamIssues that are planned to be resolved by the Spring Batch team, and not open for contributions.Issues that are planned to be resolved by the Spring Batch team, and not open for contributions.type: enhancement
Milestone
Description
As of v5.2, several public APIs declare exceptions that are not thrown, or thrown at the wrong level of abstraction. Here are a few examples:
JobRestartException
is currently defined in the data access layer (ie theorg.springframework.batch.core.repository
package where it is thrown byJobRepository#createJobExecution
) while it should be at the job operator level (thrown byJobOperator#restart(JobExecution jobExecution)
)JobOperator#start(Job job, JobParameters jobParameters)
throws aNoSuchJobException
even if the job is passed as a parameter (ie it is not just an id that should be fetched from the registry and which might result in aNoSuchJobException
if the job is not recognised)JobOperator#restart(JobExecution jobExecution)
throws aNoSuchJobExecutionException
even if the exception is passed as a parameter (similar to the previous point)org.springframework.batch.item.file.transform.ConversionException
is not usedorg.springframework.batch.item.validator.ValidationException
currently extendsItemReaderException
but it is not related to item reading, it is used by the item processor when validating items
This should be reviewed in v6
Metadata
Metadata
Assignees
Labels
api: breaking-changeIssues that require or introduce an API breaking changeIssues that require or introduce an API breaking changein: corein: infrastructurein: integrationin: teststatus: for-internal-teamIssues that are planned to be resolved by the Spring Batch team, and not open for contributions.Issues that are planned to be resolved by the Spring Batch team, and not open for contributions.type: enhancement