Provide Support for Java 8 LocalDateTime for the case of FieldSetMapper and CustomDateEditor [BATCH-2778]

[spring-projects-issues]

Prateek opened BATCH-2778 and commented

The complete question posted here: https://stackoverflow.com/questions/53615922/field-error-in-object-target-on-field-rejected-value-codes-typemismat/53656571#53656571

One thing, it looks like Redis somehow not formatting the date correctly.

---

No further details from BATCH-2778

[spring-projects-issues]

Mahmoud Ben Hassine commented

As mentioned in SO, the CustomDateEditor is from Spring Framework and not from Spring Batch, so your feature request should be opened against Spring Framework if you want this class to support Java 8 Date & Time APIs.

Moreover, you can use a custom PropertyEditor to parse LocalDateTime. Here is a passing test based on your example:

public static class Student {
	private int id;
	private String firstName, lastName;
	private LocalDateTime dateOfBirth;

	public Student() {
	}

	public Student(int id, String firstName, String lastName, LocalDateTime dateOfBirth) {
		this.id = id;
		this.firstName = firstName;
		this.lastName = lastName;
		this.dateOfBirth = dateOfBirth;
	}

	public int getId() {
		return id;
	}

	public void setId(int id) {
		this.id = id;
	}

	public String getFirstName() {
		return firstName;
	}

	public void setFirstName(String firstName) {
		this.firstName = firstName;
	}

	public String getLastName() {
		return lastName;
	}

	public void setLastName(String lastName) {
		this.lastName = lastName;
	}

	public LocalDateTime getDateOfBirth() {
		return dateOfBirth;
	}

	public void setDateOfBirth(LocalDateTime dateOfBirth) {
		this.dateOfBirth = dateOfBirth;
	}

	@Override
	public String toString() {
		return "Student{" +
				"id='" + id + '\'' +
				", firstName='" + firstName + '\'' +
				", lastName='" + lastName + '\'' +
				", dateOfBirth=" + dateOfBirth +
				'}';
	}
}

@Test
public void testLocalDateTime() throws Exception {
	DefaultLineMapper<Student> lineMapper = new DefaultLineMapper<>();

	// Delimited Line Tokenizer
	DelimitedLineTokenizer lineTokenizer = new DelimitedLineTokenizer();
	lineTokenizer.setNames("id", "firstName", "lastName", "dateOfBirth");
	lineTokenizer.setIncludedFields(new int[] {0,1,2,3});

	// Date parsing logic has been added
	HashMap<Class, PropertyEditor> customEditors = new HashMap<>();
	customEditors.put(LocalDateTime.class, new PropertyEditorSupport() {
		@Override
		public void setAsText(String text) throws IllegalArgumentException {
			setValue(LocalDateTime.parse(text, DateTimeFormatter.ISO_DATE_TIME));
		}
	});

	// Bean Wrapper Field SetMapper
	BeanWrapperFieldSetMapper<Student> fieldSetMapper = new BeanWrapperFieldSetMapper<>();
	fieldSetMapper.setTargetType(Student.class);
	fieldSetMapper.setCustomEditors(customEditors);

	lineMapper.setLineTokenizer(lineTokenizer);
	lineMapper.setFieldSetMapper(fieldSetMapper);

	Student student = lineMapper.mapLine("1,John,Doe,2011-12-03T10:15:30", 1);

	Assert.assertEquals(1, student.getId());
	Assert.assertEquals("John", student.getFirstName());
	Assert.assertEquals("Doe", student.getLastName());
	Assert.assertEquals(LocalDateTime.of(2011, 12, 3, 10, 15, 30), student.getDateOfBirth());
}

I just changed the dateOfBirth field type from java.util.Date to java.time.LocalDateTime and added a custom property editor for it.

@Prateek Do you agree?

[spring-projects-issues]

Prateek commented

Hey Mahmoud Ben Hassine - Thanks for nice suggestions. Its working very fine.

[spring-projects-issues]

Mahmoud Ben Hassine commented

Great, glad it helped!