Fix dead link to Github in contribution guide #3642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmbenhassine
added
pr-for: enhancement
in: documentation
status: waiting-for-triage
|
Hi @benoitdupont, Thank you for this PR! There is another occurrence of the same dead link at line 50: https://github.com/spring-projects/spring-batch/blob/master/CONTRIBUTING.md#L50 Could you please update the PR to fix this second dead link as well? Thank you upfront! Best regards, |
fmbenhassine
added
status: waiting-for-reporter
|
Hello, I used the same reference: GitHub help documentation for both links, it's more maintainable that way I think, or maybe you wanted to show the explicit url, or a specific name that include the label merge-request ? |
|
Awesome! Making both links point to the same reference is the way to go. Rebased, squashed and merged as 7ba73d8. Thank you! |
fmbenhassine
removed
the
status: waiting-for-reporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #3641 by replacing the dead link https://help.github.com/en/send-pull-requests by https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests