Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Javadoc of ItemProcessor regarding the nullability of input items #3648

Closed
wants to merge 1 commit into from

Conversation

mouyang
Copy link
Contributor

@mouyang mouyang commented Jan 17, 2020

…a null item.

I realized this while working on a task. I think it could prompt someone to save an unnecessary null check in an ItemProcessor. Let me know if my logic is incorrect or could be better worded.

@pivotal-issuemaster
Copy link

@mouyang Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@mouyang Thank you for signing the Contributor License Agreement!

@fmbenhassine fmbenhassine added in: documentation status: waiting-for-triage Issues that we did not analyse yet labels Jan 17, 2020
@fmbenhassine fmbenhassine added pr-for: enhancement and removed status: waiting-for-triage Issues that we did not analyse yet labels Apr 16, 2020
@fmbenhassine fmbenhassine added this to the 4.3.0 milestone Apr 16, 2020
@fmbenhassine
Copy link
Contributor

LGTM, rebased and merged as f37fae6. Thank you for your PR!

@fmbenhassine fmbenhassine changed the title Add documentation for how an ItemProcessor.process can never receive … Improve Javadoc of ItemProcessor regarding the nullability of input items May 20, 2020
@fmbenhassine fmbenhassine mentioned this pull request May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants