BATCH-2417 Drop JAXP 1.3 support #384
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring 4 requires JDK 6 which includes JAXP 1.4. In Spring 4 `org.springframework.util.xml.StaxUtils` is public and directly delegates to `javax.xml.transform.stax.StAXSource`. This means that `org.springframework.batch.item.xml.StaxUtils#hasSpring30StaxSupport` will always be true. Therefore a lot of code an be simplified by calling the constructors directly instead of through reflection. - remove reflection no longer needed in Spring 4 - move methods only used in tests to custom test class Issue: BATCH-2417
|
I have signed and agree to the terms of the SpringSource Individual |
|
Rebased and merged as 73ca736 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring 4 requires JDK 6 which includes JAXP 1.4. In Spring 4
org.springframework.util.xml.StaxUtilsis public and directlydelegates to
javax.xml.transform.stax.StAXSource. This means thatorg.springframework.batch.item.xml.StaxUtils#hasSpring30StaxSupportwill always be true. Therefore a lot of code an be simplified by
calling the constructors directly instead of through reflection.
Issue: BATCH-2417