MessageSourceAutoConfiguration does not consider @PropertySources

[klu2]

I have a testcase that uses

@PropertySource(value = "classpath:test.properties")

In this file I have:

spring.messages.basename=messages-base

And in message-base_en.properties I have some message keys that are used in the unit test, but the values cannot be found

I extracted all the required code into an own github repository: https://github.com/klu2/spring-boot-issues/

This is the test case:
https://github.com/klu2/spring-boot-issues/blob/master/autoconfigure/src/test/java/net/klu2/springboot/autoconfigure/MessageSourceAutoConfigurationTest.java

This testcase passes with spring boot 1.0.2, but it fails with spring boot 1.1.0 (you can easily check that by exchanging ext.springBootVersion in build.gradle

Most probably this commit is responsible for this issue: 0def764 (#1019)

It works fine, if the messages are in message.properties, but not in message-base.properties. It seems that @propertysource is not considered in the MessageSourceAutoConfiguration

[dsyer]

That is indeed the source of your problem. Any reason you can't just use "application.properties " for switching the location of the MessageSource?

[klu2]

Basically I could do this, but I wanted to be absolutely sure to not touch any application.properties from the classpath (as that could contain runtime/production enviroments), but only refer to propertiy files from test cases.

[dsyer]

If it's just for a test case you can use @IntegrationTest to set the message source location, or use @ActiveProfile if you want to put the settings in a file (e.g. "application-test.properties").

[klu2]

Both is not working, I pushed to branches to my repo, and the test is still failing:

klu2/spring-boot-issues@cd10a25

and

klu2/spring-boot-issues@c2f2108

[dsyer]

That last commit (d36f9ce) adds 2 tests that prove that @IntegrationTest and @ActiveProfile both work to change the message source. (Ignore the commit before that - it was supposed to reference #1074.)

[dsyer]

Postponing to 1.2 in case we can do something about the @PropertySource case (I'm not that hopeful), because the workarounds seem fine to me.