Repackage broken in gradle plugin

[jvalkeal]

trouble with boot 1.1.2/1.1.3 gradle plugin. We use custom BootRepackage task to build a boot fat jar.
https://github.com/spring-projects/spring-hadoop/blob/master/build.gradle:

task appmasterBootJar(type: BootRepackage, dependsOn: appmasterJar) {
  withJarTask = appmasterJar
  mainClass = 'org.springframework.yarn.boot.app.SpringYarnBootApplication'
}

Manifest for file test-archive-appmaster.jar is(1.1.2/1.1.3):

$ cat MANIFEST.MF 
Manifest-Version: 1.0

Manifest for file test-archive-appmaster.jar is(1.1.1):

$ cat MANIFEST.MF 
Manifest-Version: 1.0
Start-Class: org.springframework.yarn.boot.app.SpringYarnBootApplicati
 on
Spring-Boot-Version: 1.1.1.RELEASE
Main-Class: org.springframework.boot.loader.JarLauncher

Problem might be in commit f83c6aa or any other just around it. There seem to be quite a few changes to gradle plugin right after 1.1.1.

[jvalkeal]

File ./spring-yarn/spring-yarn-boot-build-tests/build/libs/test-archive-appmaster.jar is created when tests are run during the build:

$ ./gradlew clean :spring-yarn:spring-yarn-boot-build-tests:build -x javadoc -Dtest.single=YarnSubmitApplicationTests

[jvalkeal]

This is actually more broken than I first thought. With 1.1.3 boot is repackaging all created artifacts except the only one it should touch. Even artifacts for tests, sources and javadoc gets repackaged.

I assume it is a custom appmasterBootJar task which does this because main bootRepackage is disabled and skipped according to gradle.

:spring-yarn:spring-yarn-boot-build-tests:bootRepackage SKIPPED
:spring-yarn:spring-yarn-boot-build-tests:appmasterBootJar

With 1.1.3

06:45 $ ls -lt ./spring-yarn/spring-yarn-boot-build-tests/build/libs/
total 143928
-rw-r--r-- 1 jvalkealahti jvalkealahti 36839772 Jul  3 06:43 spring-yarn-boot-build-tests-2.1.0.BUILD-SNAPSHOT-tests.jar
-rw-r--r-- 1 jvalkealahti jvalkealahti 36826823 Jul  3 06:43 spring-yarn-boot-build-tests-2.1.0.BUILD-SNAPSHOT-sources.jar
-rw-r--r-- 1 jvalkealahti jvalkealahti 36826823 Jul  3 06:43 spring-yarn-boot-build-tests-2.1.0.BUILD-SNAPSHOT-javadoc.jar
-rw-r--r-- 1 jvalkealahti jvalkealahti 36831601 Jul  3 06:43 spring-yarn-boot-build-tests-2.1.0.BUILD-SNAPSHOT.jar
-rw-r--r-- 1 jvalkealahti jvalkealahti    13446 Jul  3 06:43 test-archive-appmaster.jar
-rw-r--r-- 1 jvalkealahti jvalkealahti    13446 Jul  3 06:43 spring-yarn-boot-build-tests-2.1.0.BUILD-SNAPSHOT-tests.jar.original
-rw-r--r-- 1 jvalkealahti jvalkealahti      261 Jul  3 06:43 spring-yarn-boot-build-tests-2.1.0.BUILD-SNAPSHOT-sources.jar.original
-rw-r--r-- 1 jvalkealahti jvalkealahti      261 Jul  3 06:43 spring-yarn-boot-build-tests-2.1.0.BUILD-SNAPSHOT-javadoc.jar.original
-rw-r--r-- 1 jvalkealahti jvalkealahti     5069 Jul  3 06:43 spring-yarn-boot-build-tests-2.1.0.BUILD-SNAPSHOT.jar.original

With 1.1.1

06:48 $ ls -lt ./spring-yarn/spring-yarn-boot-build-tests/build/libs/
total 38648
-rw-r--r-- 1 jvalkealahti jvalkealahti 39523507 Jul  3 06:47 test-archive-appmaster.jar
-rw-r--r-- 1 jvalkealahti jvalkealahti    13446 Jul  3 06:47 test-archive-appmaster.jar.original
-rw-r--r-- 1 jvalkealahti jvalkealahti    13446 Jul  3 06:47 spring-yarn-boot-build-tests-2.1.0.BUILD-SNAPSHOT-tests.jar
-rw-r--r-- 1 jvalkealahti jvalkealahti      261 Jul  3 06:47 spring-yarn-boot-build-tests-2.1.0.BUILD-SNAPSHOT-sources.jar
-rw-r--r-- 1 jvalkealahti jvalkealahti      261 Jul  3 06:47 spring-yarn-boot-build-tests-2.1.0.BUILD-SNAPSHOT-javadoc.jar
-rw-r--r-- 1 jvalkealahti jvalkealahti     5069 Jul  3 06:47 spring-yarn-boot-build-tests-2.1.0.BUILD-SNAPSHOT.jar

[jvalkeal]

Seeing public void execute(Jar jarTask) in RepackageTask.java:

if (isTaskMatch(jarTask, withJarTask)) {
  getLogger().info(
      "Jar task not repackaged (didn't match withJarTask): " + jarTask);
  return;
}

This fuction always exists if match happens! That would explain why all the wrong jars got repackaged and not the one which were supposed to get repackaged.

Just tried adding ! there and ran shdp build with 1.1.4.BUILD-SNAPSHOT and everything was fine from our point of view after that.

if (!isTaskMatch(jarTask, withJarTask)) {
  getLogger().info(
      "Jar task not repackaged (didn't match withJarTask): " + jarTask);
  return;
}

[wilkinsona]

Thanks for tracking this down, Janne. Looks like we need some better test coverage of this…

[wilkinsona]

I've broken war repackaging