Regression with property binding to List<String>

[marcelstoer]

With 1.5.x I used to have a property binding like this; a comma-separated String to List<String>.

@ConfigurationProperties(prefix = "foo.bar")
public class MyAppProperties {
    private final Kafka kafka = new Kafka();

    public Kafka getKafka() {
        return this.kafka;
    }

    public static class Kafka {
        private List<String> topics;
        public void setTopics(List<String> topics) {
            this.topics = topics;
        }
...

foo.bar:
    kafka:
      topics: test,failures

With Boot 2.0.2 this now fails with

Failed to bind properties under 'foo.bar.kafka.topics' to java.util.List<java.lang.String>:

    Reason: Unable to get value for property topics

Replacing List<String> in the setter with String[] fixes this.

public void setTopics(String[] topics) {
  this.topics = Lists.newArrayList(topics);
}

[snicoll]

According to the documentation, binding requires a getter. Do I understand you don't have a getter there (i.e. it's not an oversight)?

[marcelstoer]

The getter is there - below the ... in the initial snippet 😉 For the sake of completeness here it is:

public List<String> getTopics() {
  return Collections.unmodifiableList(this.topics);
}

[mbhave]

It fails when the CollectionBinder tries to get the existing value for the collection here. In this case, it's a NPE. I think we should guard against this.

[marcelstoer]

@mbhave spot on 👍 If topics is initialized with an empty collection then I don't need the String[] workaround.