Filesystem dependencies of "compile project" not included in repackaged jar

[richard-stowe]

I've just upgraded my spring boot version from 1.0.4.RELEASE to 1.1.5.RELEASE and think I may have found an issue that extends #672 and #1215.

I have a multi-project gradle build, my main application includes some of the other projects as dependencies using:

compile project(':myapplication-common')

The "myapplication-common" project includes filesystem dependencies:

compile files {"lib/myExternalJar-1.1.jar"}

Following the upgrade this filesystem based transitive dependency is no longer bundled in the boot jar, prior to the upgrade it was.

For now I'm using the following workaround in the main app gradle file:

compile files {"../myapplication-common/lib/myExternalJar-1.1.jar"}

With this workaround in place the dependency is bundled.

[dsyer]

There is actually a test for this in spring-boot-integration-tests (RepackagingTests.repackageWithFileDependency()), and it isn't failing, so could you maybe double check the versions of everything in your project? And if that doesn't explain it maybe create a minimal sample project here: https://github.com/spring-projects/spring-boot-issues)?

[richard-stowe]

Opened a pull request with a mini project that shows the issue here: spring-attic/spring-boot-issues#10

You'll see a multi-project set up, where "gh-1368-main-app" depends on "gh-1368-common". "gh-1368-common" Has 2 dependencies; guava, which is included from mavenCentral and joda-time which is a file system dependency.

If you build the project as-is, where gh-1368-main-app uses spring boot 1.1.5.RELEASE and crack open the repackaged jar once the build is complete, you'll see that the gh-1368-main-app.jar includes guava and gh-1368-common.jar but not joda-time.

If you now go to the main app gradle file and swap the commented line:

        springBootVersion = '1.1.5.RELEASE'
//        springBootVersion = '1.0.2.RELEASE'

rebuild, you'll see that this time joda-time is included in the repackaged jar.