New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-configure binding of Micrometer's JettyServerThreadPoolMetrics #14591

Closed
matsumana opened this Issue Sep 24, 2018 · 11 comments

Comments

Projects
None yet
4 participants
@wilkinsona

This comment has been minimized.

Copy link
Member

wilkinsona commented Sep 24, 2018

Thanks for the suggestion. We can take a look at what's possible, but I don't think we can implement this in the same way as has been done in Micrometer. The biggest problem is that, if a user has customised Jetty's thread pool, the auto-configuration will overwrite that customisation.

@wilkinsona

This comment has been minimized.

Copy link
Member

wilkinsona commented Sep 25, 2018

I asked a few questions on the Micrometer PR. We'll need some feedback on those to make progress on this one.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented Oct 2, 2018

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@matsumana

This comment has been minimized.

Copy link

matsumana commented Oct 8, 2018

I commented in micrometer-metrics/micrometer#593 (comment).
Could you please check it?

@wilkinsona

This comment has been minimized.

Copy link
Member

wilkinsona commented Oct 8, 2018

Thanks. I've taken a look. Unfortunately, the problem with overwriting the user's thread pool customisation remains.

@wilkinsona wilkinsona changed the title Add Support for Jetty's Thread Pool metrics auto configuration Auto-configure binding of Micrometer's JettyThreadPoolMetrics Oct 13, 2018

@wilkinsona wilkinsona added this to the 2.1.x milestone Oct 13, 2018

@wilkinsona wilkinsona self-assigned this Oct 13, 2018

@wilkinsona wilkinsona changed the title Auto-configure binding of Micrometer's JettyThreadPoolMetrics Auto-configure binding of Micrometer's JettyServerThreadPoolMetrics Oct 13, 2018

@wilkinsona wilkinsona modified the milestones: 2.1.x, 2.1.0.RC1 Oct 13, 2018

@wilkinsona

This comment has been minimized.

Copy link
Member

wilkinsona commented Oct 13, 2018

FYI, @izeye. I think this approach is better than the one that we discussed on the Micrometer PR and the one that Boot was using for TomcatMetrics.

@izeye

This comment has been minimized.

Copy link
Contributor

izeye commented Oct 14, 2018

@wilkinsona Thanks for sharing! I'd like to align Spring Boot 1.5.x support with this but ApplicationStartedEvent has been introduced since 2.0.0. Is there any recommendation for Spring Boot 1.5.x?

@wilkinsona

This comment has been minimized.

Copy link
Member

wilkinsona commented Oct 14, 2018

ApplicationReadyEvent is a reasonable substitute.

@izeye

This comment has been minimized.

Copy link
Contributor

izeye commented Oct 14, 2018

@wilkinsona Thanks for the quick feedback! I'll try with it.

@izeye

This comment has been minimized.

Copy link
Contributor

izeye commented Oct 14, 2018

@wilkinsona I created micrometer-metrics/micrometer#925 and micrometer-metrics/micrometer#926 to align Spring Boot 1.5.x support with this approach.

jkschneider added a commit to micrometer-metrics/micrometer that referenced this issue Oct 14, 2018

jkschneider added a commit to micrometer-metrics/micrometer that referenced this issue Oct 14, 2018

@matsumana

This comment has been minimized.

Copy link

matsumana commented Oct 15, 2018

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment