Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default no-op method implementations to SpringApplicationRunListener #16030

Closed
philwebb opened this issue Feb 25, 2019 · 4 comments
Closed

Add default no-op method implementations to SpringApplicationRunListener #16030

philwebb opened this issue Feb 25, 2019 · 4 comments
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@philwebb
Copy link
Member

See reactor/BlockHound#8 (comment)
@philwebb philwebb modified the milestones: 2.1.x, 2.2.x Feb 25, 2019
@philwebb philwebb added the type: task A general task label Feb 25, 2019
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed type: task A general task labels Feb 26, 2019
@wilkinsona
Copy link
Member

I've changed this to an enhancement as the proposed change will allow users who've implemented SpringApplicationRunListener to delete some code.

@ayudovin
Copy link
Contributor

ayudovin commented Mar 2, 2019

@philwebb, @wilkinsona, I want to work on it. Please let me know if I can start working on it?

@wilkinsona
Copy link
Member

@ayudovin A PR would be most welcome. Thanks for the offer.

@ayudovin ayudovin mentioned this issue Mar 5, 2019
Closed
@mbhave
Copy link
Contributor

mbhave commented Mar 12, 2019

Closing in favor of PR #16104.

@mbhave mbhave closed this as completed Mar 12, 2019
@mbhave mbhave added the status: superseded An issue that has been superseded by another label Mar 12, 2019
@mbhave mbhave removed this from the 2.2.x milestone Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@philwebb @wilkinsona @mbhave @ayudovin