`spring run` help documentation shows `--cp`

[nebhale]

Currently the output of spring help run shows:

bhale-desktop 62838890-boot-m7: spring help run
spring run - Run a spring groovy script

usage: spring run [options] <files> [--] [args]

Option                     Description                          
------                     -----------                          
--autoconfigure [Boolean]  Add autoconfigure compiler           
                             transformations (default: true)    
--classpath, --cp          Additional classpath entries         
-e, --edit                 Open the file with the default system
                             editor                             
--no-guess-dependencies    Do not attempt to guess dependencies 
--no-guess-imports         Do not attempt to guess imports      
-q, --quiet                Quiet logging                        
-v, --verbose              Verbose logging                      
--watch                    Watch the specified file for changes 

In this output, the indication is that it requires a double dash (i.e. --) before the cp argument. This isn't the typical syntax for short arguments and does not match either the other arguments to run or java:

bhale-desktop 62838890-boot-m7: java
Usage: java [-options] class [args...]
           (to execute a class)
   or  java [-options] -jar jarfile [args...]
           (to execute a jar file)
where options include:
    -d32      use a 32-bit data model if available
    -d64      use a 64-bit data model if available
    -server   to select the "server" VM
                  The default VM is server,
                  because you are running on a server-class machine.


    -cp <class search path of directories and zip/jar files>
    -classpath <class search path of directories and zip/jar files>
                  A : separated list of directories, JAR archives,
                  and ZIP archives to search for class files.

If this is simply a documentation problem, the documentation needs to be updated. If this is a functionality discrepancy, this should be brought into line with standard behavior.

[philwebb]

Unfortunately this is a feature of the underlying joptsimple library that we use. Only single characters options use single hyphens.

It will not be easy to fix either as -cp is actually interpreted as -c -p [1]. Perhaps we should just drop --cp or alternatively support -c.

[1] http://pholser.github.io/jopt-simple/examples.html

[nebhale]

My feeling (based solely on, you know..., me) is that there is an expectation that -cp is an option and the spelling of that option. I can't think of a mainstream Java utility where it isn't available and doesn't use the single dash. I realize that this means lots of work for you guys, but at the same time, it will help the product fit into the Java ecosystem.

[dsyer]

This turned out to be easier than we thought - jopt supports "-cp" as a synonym for "--cp" out of the box, so all we had to do was print it in the help text.

[philwebb]

Fix 045088e adds -cp for bash/zsh completion but does not fix the help output (e.g. spring help run)