java -jar fails to read aspectjrt 1.7.4

[PerGon]

Hi there,

I have this gradle.build config file:

buildscript {
    repositories {
        maven { url "http://repo.spring.io/libs-snapshot" }
        mavenLocal()
    }
    dependencies {
        classpath("org.springframework.boot:spring-boot-gradle-plugin:0.5.0.M7")
    }
}

apply plugin: 'spring-boot'
apply plugin: 'java'
apply plugin: 'idea'

sourceCompatibility = 1.7
version = '0.1-alpha'

compileJava.options.encoding = 'UTF-8'

repositories {
    mavenCentral()
    maven { url "http://repo.spring.io/libs-snapshot" }
}

jar {
    manifest {
        attributes 'Implementation-Title': 'SysMonCore', 'Implementation-Version': version
        manifest.attributes("Main-Class": "com.sysmon.Application")
    }

    println "gradle version -> " + gradle.gradleVersion

    doLast{
        copy {
            from 'application.properties'
            from 'keystore.pfx'
            into 'build/libs'
        }
    }
}

dependencies {
    compile 'org.springframework.boot:spring-boot-starter-web:0.5.0.M7',
            'org.springframework.boot:spring-boot-starter-aop:0.5.0.M7',
            'org.springframework.boot:spring-boot-starter-data-jpa:0.5.0.M7',
            'org.springframework.boot:spring-boot-starter-jdbc:0.5.0.M7',
            'org.springframework.boot:spring-boot-starter-security:0.5.0.M7',
            'com.google.guava:guava:15.0',
            'mysql:mysql-connector-java:5.1.27',
            'org.projectlombok:lombok:1.12.2',
            'org.codehaus.groovy:groovy:2.1.9',
            'com.fasterxml.jackson.core:jackson-databind:2.3.0'
}

task wrapper(type: Wrapper) { gradleVersion = '1.10' }

Nothing fancy, I guess.
When I build using the spring-boot version 0.5.0.M6, everything works well. I do "java -jar myapp.jar" and my app starts nice and neat.

But after updating to spring-boot version 0.5.0.M7 (as seen in my gradle.config), I do "java -jar myapp.jar" and I get this stacktrace error:

java.lang.reflect.InvocationTargetException
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.springframework.boot.loader.MainMethodRunner.run(MainMethodRunner.java:53)
    at java.lang.Thread.run(Thread.java:724)
Caused by: java.lang.NoClassDefFoundError: org/aspectj/lang/ProceedingJoinPoint
    at java.lang.Class.getDeclaredMethods0(Native Method)
    at java.lang.Class.privateGetDeclaredMethods(Class.java:2521)
    at java.lang.Class.getDeclaredMethods(Class.java:1845)
    at org.springframework.orm.jpa.support.PersistenceAnnotationBeanPostProcessor.findPersistenceMetadata(PersistenceAnnotationBeanPostProcessor.java:402)
    at org.springframework.orm.jpa.support.PersistenceAnnotationBeanPostProcessor.postProcessMergedBeanDefinition(PersistenceAnnotationBeanPostProcessor.java:332)
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyMergedBeanDefinitionPostProcessors(AbstractAutowireCapableBeanFactory.java:908)
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:512)
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:475)
    at org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:304)
    at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:228)
    at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:300)
    at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:195)
    at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:700)
    at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:760)
    at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:482)
    at org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.refresh(EmbeddedWebApplicationContext.java:124)
    at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:609)
    at org.springframework.boot.SpringApplication.run(SpringApplication.java:321)
    at org.springframework.boot.SpringApplication.run(SpringApplication.java:806)
    at org.springframework.boot.SpringApplication.run(SpringApplication.java:795)
    at com.sysmon.Application.main(Application.java:20)
    ... 6 more
Caused by: java.lang.ClassNotFoundException: org.aspectj.lang.ProceedingJoinPoint
    at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
    at org.springframework.boot.loader.LaunchedURLClassLoader.findClass(LaunchedURLClassLoader.java:148)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
    at org.springframework.boot.loader.LaunchedURLClassLoader.doLoadClass(LaunchedURLClassLoader.java:131)
    at org.springframework.boot.loader.LaunchedURLClassLoader.loadClass(LaunchedURLClassLoader.java:103)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
    ... 27 more
Caused by: java.util.zip.ZipException: invalid stored block lengths
    at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:164)
    at org.springframework.boot.loader.jar.ZipInflaterInputStream.read(ZipInflaterInputStream.java:52)
    at sun.misc.Resource.getBytes(Resource.java:124)
    at java.net.URLClassLoader.defineClass(URLClassLoader.java:444)
    at java.net.URLClassLoader.access$100(URLClassLoader.java:71)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
    ... 35 more
2014-01-09 13:43:29.826  INFO 6930 --- [       Thread-2] ationConfigEmbeddedWebApplicationContext : Closing org.springframework.boot.context.embedded.AnnotationConfigEmbeddedWebApplicationContext@4018f058: startup date [Thu Jan 09 13:43:21 CET 2014]; root of context hierarchy
2014-01-09 13:43:29.857  WARN 6930 --- [       Thread-2] ationConfigEmbeddedWebApplicationContext : Exception thrown from LifecycleProcessor on context close

java.lang.IllegalStateException: LifecycleProcessor not initialized - call 'refresh' before invoking lifecycle methods via the context: org.springframework.boot.context.embedded.AnnotationConfigEmbeddedWebApplicationContext@4018f058: startup date [Thu Jan 09 13:43:21 CET 2014]; root of context hierarchy
    at org.springframework.context.support.AbstractApplicationContext.getLifecycleProcessor(AbstractApplicationContext.java:359)
    at org.springframework.context.support.AbstractApplicationContext.doClose(AbstractApplicationContext.java:888)
    at org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.doClose(EmbeddedWebApplicationContext.java:153)
    at org.springframework.context.support.AbstractApplicationContext$1.run(AbstractApplicationContext.java:809)

2014-01-09 13:43:29.858  INFO 6930 --- [       Thread-2] j.LocalContainerEntityManagerFactoryBean : Closing JPA EntityManagerFactory for persistence unit 'default'
2014-01-09 13:43:29.867  INFO 6930 --- [ost-startStop-1] com.sysmon.ApplicationBootstrap          : ServletContext destroyed

It doesn't find the class "org.aspectj.lang.ProceedingJoinPoint", and the corresponding jar is in place. I guess the problem is somewhere here: java.util.zip.ZipException: invalid stored block lengths. But I have no clues where to start!

[dsyer]

Is the JAR file containing that class really a proper JAR archive? Maybe it got cached in a funny state? I'm not a Gradler so I don't know how to force it to refresh (find it and delete it locally maybe).

[philwebb]

I tried building https://spring.io/guides/gs/rest-service/ with M7 and it seemed to run using java -jar. Are you able to provide a project that reproduces the issue?

[gregturn]

For starters, spring-boot-starter-data-jpa pulls in spring-boot-starter-aop
and spring-boot-starter-jpa, so those are redundant.

I have edited http://spring.io/guides/gs/accessing-data-jpa to use:

dependencies {
compile("org.springframework.boot:spring-boot-starter-web:0.5.0.M7")

compile("org.springframework.boot:spring-boot-starter-data-jpa:0.5.0.M7")
compile("com.h2database:h2:1.3.172")
testCompile("junit:junit:4.11")
}

...and it works fine. So I would suggest you clean out your gradle cache
and try to rebuild.

On Thu, Jan 9, 2014 at 3:05 PM, Phil Webb notifications@github.com wrote:

I tried building https://spring.io/guides/gs/rest-service/ with M7 and it
seemed to run using java -jar. Are you able to provide a project that
reproduces the issue?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/203#issuecomment-31976132
.

Greg Turnquist | Senior Software Engineer | Pivotal
Mobile: +1 321-759-1143 | Skype: gregturn | gturnquist@gopivotal.com

goPivotal.com http://www.gopivotal.com/

[PerGon]

Thank you all for your quick responses.

I narrow down the problem a little bit. I'm using M7 for all the dependencies except for spring-boot-gradle-plugin (using M6 for this one), and it works. If I use spring-boot-gradle-plugin M7 it gives the exception of the first post.

@dsyer @gregturn , I cleaned the gradle cache, and same problem!
@gregturn thanks for clarify the starters for me ;) (I guess you mean data-jpa pulls aop and jdbc)
@philwebb I'll try to make a simple app that reproduces the problem.

[PerGon]

@philwebb hope this can help: https://github.com/PerGon/spring-boot-gradle-bug

[dsyer]

That's really useful thanks. I used that project to git bisect and found the problem commit d2678e0 (the one where you added a load of performance improvements @philwebb).

[dsyer]

Another useful fact (and a workaround): if you fix the aspectj version to 1.7.3 (instead of 1.7.4) it works. So there is something weird about that jar.

[philwebb]

@PerGon Thanks for the repro project! I will take a look. Commit d2678e0 changed the way that we read zip files, I imagine that there is something in aspectj 1.7.4 that we don't deal with correctly.

[philwebb]

What an absolutely horrible bug that was to track down. See the commit message in d125357 for details.

Thanks again for raising this and for the repro project.

[PerGon]

Glad to be helpful! Keep up the great work :)