Revisit datasource initialization so that no other component block on the EMF while it is being initialized

[snicoll]

Fix for #23735 in 2.3.x.

Given that 2.3.5 has not been released yet, I am flagging this one as a task as a follow-up of #22852.

[snicoll]

HibernateMetricsAutoConfiguration takes a map of String to EMF beans and register metrics. This happening with parallel initialisation means that a deadlock can be happening.

I've moved locally that code to SmartInitializingSingleton#afterSingletonsInstantiated and that did the trick for me but I'd like to confirm that this is the right approach before changing anything in 2.3.x.

[snicoll]

I've reproduced the problem in our smoke test for JPA.