spring.profiles.include is silently ignored when used in a profile-specific document

[wilkinsona]

See #22693 for the introduction of failing hard and #22944 which relaxed things a little to allow its use in non-profile-specific documents. As things stand, it would appear that spring.profiles.include is being silently ignored when used in a profile-specific document.

At the least, I think we should update the release notes on the wiki as there's no mention of spring.profiles.include at the moment. Ideally, I think we'd also fail hard when spring.profiles.include is used in a profile-specific document. Flagging for team attention to see what the rest of the team thinks.

[perilbrain]

But please allow use of legacy flags. I have reverted to old method as the new method is yet unable to address few problems( #24720 ) and will take some time to mature when new issues pop up.

[philwebb]

I've been unable to replicate this with the latest 2.4.x. @perilbrain Do you have a sample project that shows the silent failure?

[perilbrain]

I've been unable to replicate this with the latest 2.4.x. @perilbrain Do you have a sample project that shows the silent failure?

In #24720 I have attached a file. All you need is to remove spring.config.use-legacy-processing=true from application.properties after bootstrapping. Here is what you'll see

With application.properties like:

# ==========================
# Dont touch legacy support
# ==========================
spring.config.use-legacy-processing=true

spring.profiles.active=local

result will be

$> http :8080/who
Active Profile Details: envType=application-local.properties, password=prod, common='from_common_profile'

When legacy removed in application.properties

# ==========================
# Dont touch legacy support
# ==========================
# spring.config.use-legacy-processing=true

spring.profiles.active=local

result will be

$> http :8080/who
Active Profile Details: envType=application-local.properties, password=MissingPassword, common='MissingCommon'

And yes application keeps on running without any hard fail.