Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Maven version in system requirements with what is actually tested #26207

Closed
1 of 4 tasks
snicoll opened this issue Apr 22, 2021 · 4 comments
Closed
1 of 4 tasks
Assignees
Labels
status: first-timers-only An issue that can only be worked on by brand new contributors status: superseded An issue that has been superseded by another type: documentation A documentation update

Comments

@snicoll
Copy link
Member

snicoll commented Apr 22, 2021

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before, consider leaving this one for someone new, and looking through our general ideal-for-contribution issues. Thanks!

Problem

The documentation that lists the supported Maven versions states that Spring Boot supports Maven 3.3 and later. While we don't expect this to be problematic, our Maven Plugin is only tested as of Maven 3.5 onwards.

Solution

The documentation should be updated to changes the version from 3.3.+ to 3.5.+. This should be done in spring-boot-project/spring-boot-docs/src/docs/asciidoc/getting-started.adoc.

Steps to Fix

  • Claim this issue with a comment below and ask any clarifying questions you need
  • Set up a repository locally following the Contributing Guidelines
  • Try to fix the issue following the steps above
  • Commit your changes and start a pull request.
@snicoll snicoll added type: documentation A documentation update status: first-timers-only An issue that can only be worked on by brand new contributors labels Apr 22, 2021
@snicoll snicoll added this to the 2.3.x milestone Apr 22, 2021
@zoosm3
Copy link
Contributor

zoosm3 commented Apr 22, 2021

Hello, I am interested in the contribution.
Is that only document fix? Or should we modify source code?

@snicoll
Copy link
Member Author

snicoll commented Apr 22, 2021

Hello @zoosm3, the issue is all yours. The Solution describes what needs to be done and it is a documentation fix, indeed.

@zoosm3
Copy link
Contributor

zoosm3 commented Apr 22, 2021

Hello @snicoll, thank you very much for your reply and giving me the opportunity. I just opened #26209.

@snicoll
Copy link
Member Author

snicoll commented Apr 22, 2021

Great. Closing in favor of #26209

@snicoll snicoll closed this as completed Apr 22, 2021
@snicoll snicoll added the status: superseded An issue that has been superseded by another label Apr 22, 2021
@snicoll snicoll removed this from the 2.3.x milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: first-timers-only An issue that can only be worked on by brand new contributors status: superseded An issue that has been superseded by another type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

2 participants