Use RequestContextFilter instead of RequestContextListener

[cemo]

We have an issue with Spring Session with RequestContextListener described at here. This is issue opened as a request by @philwebb.

Basically ContextListener is setting request very early and it should be set after Spring Session Filter. RequestContextFilter has a nice advantage over listener. Filter is setting response as well and accessing Response by a static reference as Request is very useful. Please consider changing default behaviour to RequestContextFilter.

[dsyer]

If it's a filter the only problem is how to choose an order for it. I guess we might need to make that configurable, and make sure it lands after the Spring Session filter if that is present (e.g. when we support it via auto-configuration).

[rwinch]

@cemo Can you elaborate on where you are accessing the RequestContextHolder? This is important because the RequestContextFilter must be after SessionRepositoryFilter and before you are accessing RequestContextHolder.

[prasenjit-net]

After working with spring-session with distributed session, i feel that there should be proper way to overwrite the default session in servlet-api

[wilkinsona]

Ping @cemo. Please see the question above from @rwinch

[cemo]

Sorry for late reply.

We are using RequestContextHolder in many places. In Services, Validators, Security Filters etc... Currently I had done exactly how @rwinch described to create a workaround.

I believe that Filter approach is superior because of setting not only request but also response. A Listener can only set Request, but a filter can set Response as well.

Using a listener may cause issues to access not Spring Session wrapped ServletRequest

[cemo]

This issue might see not important very much but there is not any solution to use currently RequestContextHolder without RequestContextFilter in Spring Boot land. Spring Boot's current implementation is based on RequestContextListener and anyone using Spring Session + Spring Boot + RequestContextHolder without RequestContextFilter will have a problem. @wilkinsona, please reconsider to schedule this to 1.3 release.

[cemo]

also ping @rwinch