Likely issues of incorrect classloader being used

[jaminh]

I found additional places in the code that look like they likely could cause issues when an alternate classloader is used for a SpringApplication, but I have not actually experienced an issue yet.

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/env/SpringApplicationJsonEnvironmentPostProcessor.java

Line 161 in f06b784

if (ClassUtils.isPresent(SERVLET_ENVIRONMENT_CLASS, null)) {

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/json/JsonParserFactory.java

Line 39 in f06b784

if (ClassUtils.isPresent("com.fasterxml.jackson.databind.ObjectMapper", null)) {

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/reactor/DebugAgentEnvironmentPostProcessor.java

Line 44 in f06b784

if (ClassUtils.isPresent(REACTOR_DEBUGAGENT_CLASS, null)) {

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/jetty/SslServerCustomizer.java

Line 131 in f06b784

return ClassUtils.isPresent("org.eclipse.jetty.alpn.server.ALPNServerConnectionFactory", null);

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/BeanDefinitionLoader.java

Line 227 in f06b784

return ClassUtils.isPresent("groovy.lang.MetaClass", null);

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/WebApplicationType.java

Line 67 in f06b784

if (!ClassUtils.isPresent(className, null)) {

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/WebApplicationType.java

Line 86 in f06b784

return ClassUtils.resolveClassName(target, null).isAssignableFrom(type);

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/jdbc/DataSourceBuilder.java

Line 487 in f06b784

return (V) ClassUtils.resolveClassName(value, null);

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/validation/MessageInterpolatorFactory.java

Line 77 in f06b784

Class<?> interpolatorClass = ClassUtils.resolveClassName(fallback, null);

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/context/config/DelegatingApplicationContextInitializer.java

Line 73 in f06b784

Class<?> initializerClass = ClassUtils.forName(className, ClassUtils.getDefaultClassLoader());

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/context/config/DelegatingApplicationListener.java

Line 82 in f06b784

Class<?> clazz = ClassUtils.forName(className, ClassUtils.getDefaultClassLoader());

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/context/properties/ConfigurationPropertiesScanRegistrar.java

Line 103 in f06b784

register(registrar, ClassUtils.forName(className, null));

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/jetty/JasperInitializer.java

Line 57 in f06b784

Class<?> initializerClass = ClassUtils.forName(className, null);

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/servlet/support/ErrorPageFilter.java

Line 306 in f06b784

collection.add(ClassUtils.forName(className, null));

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/BeanDefinitionLoader.java

Line 195 in f06b784

load(ClassUtils.forName(resolvedSource, null));

[philwebb]

Also

Similar to issues #27071 and #27072 the YamlPropertySourceLoader does not use an alternate classloader if one is provided to the SpringApplication. The problem can be found here

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/env/YamlPropertySourceLoader.java

Line 46 in f06b784

if (!ClassUtils.isPresent("org.yaml.snakeyaml.Yaml", null)) {

.

[wilkinsona]

Thanks for this. While a number of these look similar to #27133, there are others where someone may be relying on the current behaviour. Until someone reports a concrete problem we'd prefer to leave things as they are and avoid the risk of introducing a subtle regression.