Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Spring Boot RC2 can't read spring.main.show_banner #346

Closed
cbelleza opened this Issue Feb 13, 2014 · 4 comments

Comments

Projects
None yet
5 participants

Hi all,

I added RC2 to my project and noticed that spring.main.show_banner = false doesn't work anymore in application.properties. Now shows a banner, but in RC1 worked nicely.

Would it be a regression bug?

Many thanks!

I've got the same issue using application.yml file:

spring:
  main:
    show_banner: false

The documentation also seems to be somewhat conflicting on whether the key should be show-banner or show_banner:
howto.md says show_banner
application.yml says show-banner
ConfigFileApplicationListener.java says show_banner

Using RC1, both show-banner and show_banner seem to work.

@wilkinsona wilkinsona self-assigned this Feb 13, 2014

Owner

dsyer commented Feb 13, 2014

The binder is relaxed about the key name so all of those should work (as should SHOW_BANNER, showBanner, etc.). That doesn't explain why it stopped working (but @philwebb probably knows).

Member

wilkinsona commented Feb 13, 2014

It's working again in the latest snapshots, i.e. post RC2 I was mistaken, it's broken on master

@philwebb philwebb assigned philwebb and unassigned wilkinsona Feb 13, 2014

@philwebb philwebb added this to the 1.0.0.RC3 milestone Feb 13, 2014

@philwebb philwebb modified the milestone: 1.0.0.RC3, 1.0.0.RC4 Feb 13, 2014

@philwebb philwebb closed this in 97c258a Feb 13, 2014

Owner

philwebb commented Feb 13, 2014

We will push RC3 later today since this is such an important bug.

@philwebb philwebb removed the in progress label Feb 13, 2014

@philwebb philwebb referenced this issue in spring-io/sagan Feb 13, 2014

Merged

Upgrade to Spring Boot 1.0.0.RC3 #272

@gigfork gigfork pushed a commit to boostrack/spring-boot that referenced this issue Apr 21, 2014

@philwebb philwebb Fix properties binding to SpringApplication
Fix ConfigFileApplicationListener to correctly bind
`application.properties` to SpringApplication. Binding in RC2 failed
due to the fact that `ConfigurationPropertySources` did not extend
`EnumerablePropertySource`.

Fixes gh-346
139489d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment