Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a condition for threading (platform or virtual) #36624

Closed
mhalbritter opened this issue Jul 28, 2023 · 1 comment
Closed

Provide a condition for threading (platform or virtual) #36624

mhalbritter opened this issue Jul 28, 2023 · 1 comment
Assignees
@mhalbritter
Labels
theme: virtual-threads Issues related to supporting Java 21's virtual threads type: enhancement A general enhancement
Milestone
3.2.0-M2

Comments

@mhalbritter
Copy link
Contributor

mhalbritter commented Jul 28, 2023 •
edited

Would be good to have a @ConditionalOnPlatformThreads which is the negation of @ConditionalOnVirtualThreads.
@mhalbritter mhalbritter added type: enhancement A general enhancement theme: virtual-threads Issues related to supporting Java 21's virtual threads labels Jul 28, 2023
@mhalbritter mhalbritter added this to the 3.2.x milestone Jul 28, 2023
@mhalbritter mhalbritter self-assigned this Jul 28, 2023
mhalbritter added a commit to mhalbritter/spring-boot that referenced this issue Jul 28, 2023
@mhalbritter
Implement @ConditionalOnPlatformThreads
2b6be87 
Closes spring-projectsgh-36624
mhalbritter added a commit to mhalbritter/spring-boot that referenced this issue Jul 28, 2023
@mhalbritter
Implement @ConditionalOnPlatformThreads
0cf4911 
Closes spring-projectsgh-36624
@mhalbritter
Copy link
Contributor Author

mhalbritter commented Jul 28, 2023 •
edited

After some consideration, we now use @ConditionalOnThreading(Threading.PLATFORM) for platform threads and @ConditionalOnThreading(Threading.VIRTUAL) for virtual threads.

This was referenced Jul 28, 2023
Closed
Closed
mhalbritter added a commit that referenced this issue Jul 28, 2023
@mhalbritter
Remove @ConditionalOnVirtualThreads
1347b99 
See gh-36624
See gh-35892
@mhalbritter mhalbritter modified the milestones: 3.2.x, 3.2.0-M2 Jul 28, 2023
@wilkinsona wilkinsona changed the title Provide a condition for platform threads Provide a condition for threading (platform or virtual) Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhalbritter mhalbritter

Labels
theme: virtual-threads Issues related to supporting Java 21's virtual threads type: enhancement A general enhancement
Projects
None yet
Milestone
3.2.0-M2
Development

No branches or pull requests
1 participant
@mhalbritter