-
Notifications
You must be signed in to change notification settings - Fork 41.5k
Description
I was about to open a few issues related to the OpenTelemetry support in Spring/Micrometer and volunteer to implement some of the existing ones, but I thought that it might help gathering here what's the current status so to put each issue within the right context and perspective. Looking at the bigger picture helps me explain some of those issues without pointing the reader to too many different GitHub issues. And I hope it will help everyone who joins the conversation. If this is not the right place to share such information, please let me know and I'll fix it accordingly.
I'll be happy to discuss this topic further and contribute pull requests as needed.
TL;DR; I go through a few issues and suggestions to consolidate OpenTelemetry support in Spring and unifying the configuration for metrics and traces (and enabling doing the same for logs in the future).
Metrics
Spring Boot Actuator provides dependency management and autoconfiguration for Micrometer, which offers a convenient facade over many different monitoring systems. One of them is OpenTelemetry.
Spring Boot developers can enable their applications to export metrics via the OTLP protocol to an OpenTelemetry backend by adding Spring Boot Actuator and the dedicated OpenTelemetry dependency from Micrometer to their projects.
dependencies {
implementation 'org.springframework.boot:spring-boot-starter-actuator'
runtimeOnly 'io.micrometer:micrometer-registry-otlp'
...
}
The exporter provided by the Micrometer Registry OTLP is an HTTP exporter and can be configured via properties thanks to the autoconfiguration for OpenTelemetry.
management:
otlp:
metrics:
export:
url: http://localhost:4318/v1/metrics
step: 5s
OpenTelemetry supports additional key/value pairs (called resource attributes
) to be included in the telemetry data. Spring Boot Actuator provides autoconfiguration for those and makes it possible to add new resource attributes via properties.
management:
opentelemetry:
resource-attributes:
cluster: local
"service.name": ${spring.application.name}
I made a demo application to showcase this setup.
Issue M.1 - Wrong autoconfiguration in Spring Boot 3.2
In this pull request delivered to spring Boot 3.2.0, some OpenTelemetry configuration regarding resource attributes has been consolidated to be able to share it between metrics and traces implementations (which is really great and useful, thanks for that!).
That works fine when using OpenTelemetry for tracing, but when it's used only for metrics the autoconfiguration doesn't work. The OpenTelemetryProperties
bean which is now autowired in the OtlpMetricsExportAutoConfiguration
requires the OpenTelemetry SDK to be in the classpath. However, the Micrometer Registry OTLP library doesn't include the OpenTelemetry SDK, causing the autoconfiguration to fail.
A workaround for now is to add an explicit dependency to OpenTelemetry SDK and rely on the Spring Boot dependency management to resolve the correct version.
dependencies {
implementation 'org.springframework.boot:spring-boot-starter-actuator'
runtimeOnly 'io.micrometer:micrometer-registry-otlp'
// Added dependency
implementation 'io.opentelemetry:opentelemetry-sdk-common'
}
Possible solutions:
- include workaround to the Spring Boot Actuator documentation;
- add missing dependency as part of the autoconfiguration;
- wait until further consolidation activities have been completed to unify the OpenTelemetry support in Spring.
Issue M.2 - Service Name resource attribute is set to "unknown_service"
By default, Micrometer Registry OTLP includes a few resource attributes to the exported metrics (see the full list). One of them is the standard service.name
OpenTelemetry attribute. The default value for this attribute is unknown_service
since the library can't know the name of the application being instrumented.
Relying on the Spring Boot Actuator autoconfiguration for OpenTelemetry resource attributes, developers can overwrite the value of service.name
with the actual name of the application as configured in Spring Boot (spring.application.name
).
management:
opentelemetry:
resource-attributes:
"service.name": ${spring.application.name}
Since Spring Boot can tell if an application name has been configured, it would be nice if some autoconfiguration existed to do that out-of-the-box. Such autoconfiguration already exists in Spring Boot Actuator (see OpenTelemetryAutoConfiguration). However, that is only actually used for traces.
Possible solutions:
- leave it to the developers to assign a proper value to the
service.name
resource attribute; - add dedicated autoconfiguration only for metrics when using OpenTelemetry;
- wait until further consolidation activities have been completed to unify the OpenTelemetry support in Spring.
Issue M.3 - OTLP Metrics Exporter is HTTP-only and not configurable via OpenTelemetry
The Micrometer Registry OTLP module uses an OTLP-compatible HTTP client to export metrics to an OpenTelemetry backend. Internally, the OtlpMeterRegistry
uses a private HttpSender
object to configure the HTTP client. The benefit of this approach is that the module is lightweight and doesn't need any dependency on the OpenTelemetry SDK. It only uses the io.opentelemetry.proto
library which provides the protobuf configuration for OpenTelemetry.
On the other hand, such an approach means that:
- it's not possible to configure the metrics exporter via standard OpenTelemetry configuration;
- it's not possible to use gRPC instead of HTTP/protobuf;
- it's not possible to share OpenTelemetry configuration in Spring Boot between metrics and traces (see, for example, issue M.2).
The new generic OpenTelemetryAutoConfiguration
in Spring Boot 3.2 autoconfigures an OpenTelemetry
bean and makes it possible to configure an SdkMeterProvider
bean. What if Micrometer could use that for setting up the OpenTelemetry metrics exporter?
Possible solutions:
- update the existing Micrometer Registry OTLP module to implement a
MeterRegistry
that accepts anOpenTelemetry
object for configuration (similar to theOpenTelemetryMeterRegistry
used by the OpenTelemetry Java Instrumentation library). If backward compatibility is necessary, the new implementation would need to co-exist with the existing one (maybe a feature flag could switch between the two?); - create a new Micrometer Registry OpenTelemetry module to implement what described in the previous point, but without having issues with backward compatibility.
Building (or updating) such a module would make it possible to re-use the same OpenTelemetryAutoConfiguration
introduced in Spring Boot 3.2 for both metrics and traces (and, in the future, for logs as well).
- It would solve the issue M.1 described before since the Micrometer Registry module would have a dependency on the OpenTelemetry SDK.
- It would solve the issue M.2 described before because Micrometer would use the autoconfigured
Resource
object from OpenTelemetry to add resource attributes to the metrics. - An issue already exists on the Spring Boot project to autoconfigure an
SdkMeterProvider
bean and, in general, for using metrics with OpenTelemetry. But we are missing Micrometer support before that is doable. - It would also make it possible to switch the client implementation between HTTP and gRPC using the standard OpenTelemetry approach (i.e. configuring either an
OtlpHttpMetricExporter
orOtlpGrpcMetricExporter
). - Finally, it would make it easier for developers using Micrometer in applications together with the OpenTelemetry Java Agent or, in general, the OpenTelemetry Java Instrumentation. Those projects currently maintain a shim between Micrometer and OpenTelemetry. That shim would probably not be needed anymore. So, such a change would also reduce the workload on maintaining the OpenTelemetry Java Instrumentation compatible with Micrometer.
For more context about the current challenges, refer to this issue on the Spring Boot project.
Traces
Spring Boot Actuator provides dependency management and autoconfiguration for Micrometer Tracing, which offers a convenient facade over a few different distributed tracing backends. One of them is OpenTelemetry.
Spring Boot developers can enable their applications to export traces via the OTLP protocol to an OpenTelemetry backend by adding Spring Boot Actuator, Micrometer Tracing and the dedicated OpenTelemetry dependency from Micrometer to their projects.
dependencies {
implementation 'org.springframework.boot:spring-boot-starter-actuator'
implementation 'io.micrometer:micrometer-tracing-bridge-otel'
implementation 'io.opentelemetry:opentelemetry-exporter-otlp'
...
}
The exporter provided by the Spring Boot Actuator autoconfiguration is an HTTP exporter (an OtlpHttpSpanExporter
bean) and can be configured via properties thanks to the tracing configuration in OtlpAutoConfiguration
.
management:
otlp:
tracing:
endpoint: http://localhost:4318/v1/traces
OpenTelemetry supports additional key/value pairs (called resource attributes
) to be included in the telemetry data. Spring Boot Actuator provides autoconfiguration for those and makes it possible to add new resource attributes via properties. The standard OpenTelemetry service.name
resource attribute is configured automatically to the value of spring.application.name
(if defined) or else to a default application
value.
management:
opentelemetry:
resource-attributes:
cluster: local
I made a demo application to showcase this setup.
Issue T1 - Exporting traces via gRPC
In this issue on the Spring Boot project, autoconfiguration for an OtlpHttpSpanExporter
bean has been added to export traces via HTTP.
A common requirement is to export traces via gRPC (the most used approach in OpenTelemetry). Currently, developers can configure an OtlpGrpcSpanExporter
bean by themselves. It would be nice if Spring Boot Actuator would provide autoconfiguration for that, enhancing the existing OtlpAutoConfiguration
.
There is already an issue on the Spring Boot project to add such autoconfiguration.
Summary
Overall, these are the issues and suggestions I've been describing so far.
Current bugs in Spring Boot 3.2
- The Micrometer Registry OTLP library doesn't depend on the OpenTelemetry SDK. However, the autoconfiguration in Spring Boot Actuator does. That breaks the application if OpenTelemetry is only used for metrics.
- The OpenTelemetry autoconfiguration provided by Spring Boot Actuator for resource attributes is not used for the metrics, resulting in the standard
service.name
to be set tounkown_service
rather than to the value ofspring.application.name
.
Minimal proposed changes to consolidate OpenTelemetry support in Spring for metrics and traces
Micrometer
- Introduce a
MeterRegistry
implementation built on top of OpenTelemetry and configurable via its standard approaches, so that it's possible to share configuration between metrics and traces.
Spring Boot Actuator
- Introduce autoconfiguration for OpenTelemetry metrics. The
OpenTelemetry
andResource
beans can be reused from the existing OpenTelemetry configuration. Besides that, the autoconfiguration should define defaults forSdkMeterProvider
,OtlpHttpMetricExporter
andOtlpGrpcMetricExporter
. - Introduce autoconfiguration for exporting OpenTelemetry traces via gRPC by defining a
OtlpGrpcSpanExporter
bean. - Consolidate OpenTelemetry autoconfiguration classes across metrics and traces. The existing OpenTelemetryAutoConfiguration could be used for shared configuration. Besides that, dedicated autoconfiguration classes are needed to configure the specific exporters for each type of telemetry. Traces have that already in the OtlpAutoConfiguration.
Spring Initializr
- After going through all the previous changes, it should become straightforward adding an OpenTelemetry option to the Spring Initializr. Adding it now with the current state of things, it might make things confusing considering the different ways of configuring OpenTelemtry between metrics and traces.
Additional changes to extend OpenTelemetry support in Spring to logs
Spring Boot Actuator
- Introduce autoconfiguration for OpenTelemetry logs. The
OpenTelemetry
andResource
beans can be reused from the existing OpenTelemetry configuration. Besides that, the autoconfiguration should define defaults forSdkLoggerProvider
,OtlpHttpLogRecordExporter
andOtlpGrpcLogRecordExporter
. - Add support for Logback (default) and Log4J2. For inspiration, OpenTelemetry Java Instrumentation provides appenders for Logback and Log4J2.
- Possibly related issue on the Spring Boot project.
Further improvements
- An issue has been opened to investigate how to limit the number of configurable beans currently available in the tracing
OpenTelemetryAutoConfiguration
(this issue might be considered for the globalOpenTelemetryAutoConfiguration
once the tracing specific one gets deleted).