Duplicate warning when @EnableAutoConfiguration is declared on a class in the default package in some apps

[wilkinsona]

It doesn't happen for all apps. I saw it with @nebhale's CloudFoundry test app. I don't see it with the most basic of apps:

@EnableAutoConfiguration
class Test {

}

[wilkinsona]

Here's the output when the duplicate warning occurs:

2014-03-25 19:43:38.294  INFO 33980 --- [       runner-0] o.s.boot.SpringApplication               : Starting application on imac with PID 33980 (/Users/awilkinson/.m2/repository/org/springframework/boot/spring-boot/1.0.0.BUILD-SNAPSHOT/spring-boot-1.0.0.BUILD-SNAPSHOT.jar started by awilkinson)
2014-03-25 19:43:38.427  INFO 33980 --- [       runner-0] ationConfigEmbeddedWebApplicationContext : Refreshing org.springframework.boot.context.embedded.AnnotationConfigEmbeddedWebApplicationContext@3f9e7493: startup date [Tue Mar 25 19:43:38 GMT 2014]; root of context hierarchy
2014-03-25 19:43:39.016  WARN 33980 --- [       runner-0] o.s.b.a.AutoConfigurationPackages        : @EnableAutoConfiguration was declared on a class in the default package. Automatic @Repository scanning is not enabled.
2014-03-25 19:43:39.017  INFO 33980 --- [       runner-0] o.s.b.f.s.DefaultListableBeanFactory     : Overriding bean definition for bean 'org.springframework.boot.autoconfigure.AutoConfigurationPackages': replacing [Generic bean: class [org.springframework.boot.autoconfigure.AutoConfigurationPackages$BasePackage]; scope=; abstract=false; lazyInit=false; autowireMode=0; dependencyCheck=0; autowireCandidate=true; primary=false; factoryBeanName=null; factoryMethodName=null; initMethodName=null; destroyMethodName=null] with [Generic bean: class [org.springframework.boot.autoconfigure.AutoConfigurationPackages$BasePackage]; scope=; abstract=false; lazyInit=false; autowireMode=0; dependencyCheck=0; autowireCandidate=true; primary=false; factoryBeanName=null; factoryMethodName=null; initMethodName=null; destroyMethodName=null]
2014-03-25 19:43:39.017  WARN 33980 --- [       runner-0] o.s.b.a.AutoConfigurationPackages        : @EnableAutoConfiguration was declared on a class in the default package. Automatic @Repository scanning is not enabled.
2014-03-25 19:43:39.017  INFO 33980 --- [       runner-0] o.s.b.f.s.DefaultListableBeanFactory     : Overriding bean definition for bean 'org.springframework.boot.autoconfigure.AutoConfigurationPackages': replacing [Generic bean: class [org.springframework.boot.autoconfigure.AutoConfigurationPackages$BasePackage]; scope=; abstract=false; lazyInit=false; autowireMode=0; dependencyCheck=0; autowireCandidate=true; primary=false; factoryBeanName=null; factoryMethodName=null; initMethodName=null; destroyMethodName=null] with [Generic bean: class [org.springframework.boot.autoconfigure.AutoConfigurationPackages$BasePackage]; scope=; abstract=false; lazyInit=false; autowireMode=0; dependencyCheck=0; autowireCandidate=true; primary=false; factoryBeanName=null; factoryMethodName=null; initMethodName=null; destroyMethodName=null]

[wilkinsona]

The warning occurs once per class in the app. This very basic app with only two classes will produce two warnings:

foo.groovy

@EnableAutoConfiguration
class Foo {

}

bar.groovy

@Component
class Bar {

}

[philwebb]

Is this just on the CLI or have you seen it with a java app as well?

[wilkinsona]

Just the CLI. I think I now understand what's happening: it's because the CLI adds @EnableAutoConfiguration to every class that doesn't already have it and @EnableAutoConfiguration imports AutoConfigurationPackages.Registrar.

Things get interesting if you have a class in the default package and a class in another package. You get one message telling you repository scanning is enabled and one telling you that it's not:

2014-03-25 20:07:01.409  INFO 34305 --- [       runner-0] o.s.b.a.AutoConfigurationPackages        : @EnableAutoConfiguration was declared on a class in the package 'test'. Automatic @Repository scanning is enabled.
...
2014-03-25 20:07:01.410  WARN 34305 --- [       runner-0] o.s.b.a.AutoConfigurationPackages        : @EnableAutoConfiguration was declared on a class in the default package. Automatic @Repository scanning is not enabled.

Two classes each not in the default package is also interesting:

2014-03-25 20:10:09.461  INFO 34317 --- [       runner-0] o.s.b.a.AutoConfigurationPackages        : @EnableAutoConfiguration was declared on a class in the package 'one'. Automatic @Repository scanning is enabled.
...
2014-03-25 20:10:09.461  INFO 34317 --- [       runner-0] o.s.b.a.AutoConfigurationPackages        : @EnableAutoConfiguration was declared on a class in the package 'two'. Automatic @Repository scanning is enabled.

Beyond the duplicate messages, this also means that the base package that's stored in the application context will be getting clobbered such that only the last base package is remembered.

[philwebb]

Hmm, I guess we should really only add that annotation to one class, the problem is which one? I think for now I might just try and solve the warning issue, then we can come back to duplicate annotations after 1.0.0