OracleDataSource created by DataSourceBuilder

[cichockimc]

Spring boot version: 1.2.3.RELEASE
Language: Groovy, 2.4.3
Oracle driver: ojdbc 14

When an Oracle datasource is created it seems to be missing the username.

OracleConnectionPoolDataSource oracleDataSource  = DataSourceBuilder
      .create()
      .type(OracleConnectionPoolDataSource)
      .driverClassName('oracle.jdbc.OracleDriver')
      .url('jdbc:oracle:thin:@localhost:1521:xe')
      .username('repository')
      .password('********')
      .build()

Root cause of that is that calculateMatches method BeanPropertyMatches class is unable to link 'user' (which is expected by OracleDataSource) with 'username' which is provided by DataSourceBuilder.

Simplest workaround:

private DataSource createNewDataSource(DatasourceConnectionDetails details) {
    OracleConnectionPoolDataSource oracleDataSource  = DataSourceBuilder
      .create()
      .type(OracleConnectionPoolDataSource)
      .driverClassName(details.driverClassName)
      .url(details.url)
      .password(details.password)
      .build()
    oracleDataSource.user = 'repository'
    oracleDataSource
  }

[philwebb]

Looks similar to #1384 and I think we should just be able to change:

new RelaxedDataBinder(result).withAlias("url", "jdbcUrl").bind(properties);

to include withAlias("username", "user").

[shakuzen]

Related to #6027

On Wed, Jun 8, 2016, 01:51 Phil Webb notifications@github.com wrote:

Looks similar to #1384
#1384 and I think
we should just be able to change:

new RelaxedDataBinder(result).withAlias("url", "jdbcUrl").bind(properties);

to include withAlias("username", "user").

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6124 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AIgr7EB_1vjKtASiTMEpWzqhQoHqD23Hks5qJaGPgaJpZM4IwFBR
.

[philwebb]

Thanks @shakuzen, looks like we might have closed #6027 too soon.

[snicoll]

@philwebb unless I am missing something obvious, I disagree. This issue is about OracleConnectionPoolDataSource that has setter methods. If you look at #6027 the user is trying to bind to oracle.jdbc.pool.OracleDataSource and that one does not have any setter as far as I can see.

Maybe we should at least drop a note in the documentation about the oracle data source implementations?

[vpavic]

@snicoll I don't know if we're looking at the same thing, but oracle.jdbc.pool.OracleConnectionPoolDataSource actually extends the oracle.jdbc.pool.OracleDataSource and inherits all the setters from there.

So this issue applies to both.