ErrorController w/ servlet mappings Question

[justinmusgrove]

Hey folks, great job on boot and it is nice to see how it is changing how we are organizing projects in the enterprise.

We have a requirement where we have multiple servlet mappings pointing to dispatch servlet due to security infrastructure reasons so we modified dispatchservlet as follows:

@Configuration
@ComponentScan
@EnableAutoConfiguration
public class Application {

    public static void main(String[] args) {
        SpringApplication.run(Application.class, args);
    }

    @Bean
    public DispatcherServlet dispatcherServlet() {
        return new DispatcherServlet();
    }

    @Bean
    public ServletRegistrationBean dispatcherServletRegistration() {

        ServletRegistrationBean registration = new ServletRegistrationBean(
                dispatcherServlet(), "/audience1/*", "/audience2/*");

        registration
                .setName(DispatcherServletAutoConfiguration.DEFAULT_DISPATCHER_SERVLET_BEAN_NAME);

        return registration;
    }

}

Similar to what is described #91 when we do this the BasicErrorController is mapped to /audience1/error or /audience2/error. When an error occurs, it doesn't trigger to the error process but it does mapping of /error. Thoughts on how to handle this?

boot version: 1.0.2

[dsyer]

I believe this is not a situation we thought about handling, but let's see where we get to before we decide to do anything about it. The ErrorController is a Spring MVC controller so you just mapped it to /audience1/error and /audience2/error, which is probably fine but you didn't change the global ErrorPage (which is still mapped to /error).

• You could try adding another ErrorPage (like in ErrorMvcAutoConfiguration) with your mapping, but I'm not sure that will work and I can't see a way to switch off the existing error page.
• Maybe you can just add "/*" to the DispatcherServlet mapping?
• Or you could exclude the ErrorMvcAutoConfiguration completely in @EnableAutoConfiguration and handle it all yourself (optionally with your own instance of BasicErrorController).
• Another option is to change "error.path" to something that will be mapped by your servlet (e.g. "/audience1/error", and this will be used to register a global ErrorPage) and then add your own ErrorController with a different @RequestMapping.
• Or maybe you can do something by adding another DispatcherServlet (we haven't played with that model much, so not sure what possibilities it opens up)? I have a feeling you would have to give it its own ApplicationContext too.

[dsyer]

With that change (660d9e2, fixing a related but not identical problem with custom servlet path) you can set "server.servletPath=/extra" and "error.path=/error" and you will get the error controller on "/error" (relative to the DispatcherServlet) and an ErrorPage with "/extra/error" (so if "/extra" is mapped to the servlet it will all work). Is that helpful?

[justinmusgrove]

That helps @dsyer thank you, let me see where I get today and I will report back

• Maybe you can just add "/*" to the DispatcherServlet mapping? -> I have validated this works but just need to validate a couple of thing internally
• I tried setting error.path and implementing ErrorController going to revalidate

[justinmusgrove]

@dsyer Implementing ErrorController and changing to error.path: /audience1/customerror seemed to do the trick. Thanks again!