Adding netty dependency to classpath breaks root uri generation

[kewne]

With this controller:

//  MyController.java

@RestController
@SpringBootApplication
public class MyController {

    @PostMapping("/hello")
    public ResponseEntity<?> fakePost() {
        return ResponseEntity.created(
                fromMethodCall(MvcUriComponentsBuilder.on(MyController.class).fakePost())
                        .build()
                        .toUri())
                .build();
    }

}

And this build.gradle script:

// build.gradle
buildscript {
    repositories {
        mavenCentral()
        jcenter()
    }
    dependencies {
        classpath("org.springframework.boot:spring-boot-gradle-plugin:1.5.4.RELEASE")
    }
}
group 'spring-repro'
version '1.0-SNAPSHOT'

apply plugin: 'java'
apply plugin: 'org.springframework.boot'

sourceCompatibility = 1.8

repositories {
    mavenCentral()
}

dependencies {
    compile('org.springframework.boot:spring-boot-starter-web')
    testCompile group: 'junit', name: 'junit', version: '4.12'
    testCompile('org.springframework.boot:spring-boot-starter-test')
    // uncomment this to break the test
//    testCompile 'io.netty:netty-all:4.1.12.Final'
}

Adding the netty dependency breaks this test:

@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
@RunWith(SpringRunner.class)
public class MyControllerTest {

    @Autowired
    private TestRestTemplate testRestTemplate;

    @LocalServerPort
    private int port;

    @Test
    public void test() {
        RequestEntity<Void> request = RequestEntity.post(URI.create("/hello"))
                .build();
        ResponseEntity<Void> exchange = testRestTemplate.exchange(request, Void.class);
        URI location = exchange.getHeaders().getLocation();
        assertEquals(port, location.getPort());
        /*
             java.lang.AssertionError: 
             Expected :49676
             Actual   :-1
        */
    }

}

[snicoll]

@kewne rather than pasting the project that reproduces the problem in text, can you please share the URL to a repo we can run? That's what we'd have to do anyway to see what happens.

[kewne]

Sure, here it is: https://github.com/kewne/spring-repro

[wilkinsona]

Thanks for the sample.

The behaviour changes when you add Netty to the classpath as it causes TestRestTemplate to use a Netty-based client rather than the default client and there's a bug in Netty4ClientHttpRequest in Spring Framework. When it creates the Host header it neglects to include the port. Can you please raise a Spring Framework JIRA?

You can work around the problem by adding the following @TestConfiguration as an inner-class of MyControllerTest:

    @TestConfiguration
    static class RestTemplateBuilderConfiguration {

    	@Bean
    	public RestTemplateBuilder restTemplateBuilder() {
    		return new RestTemplateBuilder().requestFactory(SimpleClientHttpRequestFactory.class);
    	}

    }

[bclozel]

Fixed in https://jira.spring.io/browse/SPR-15706