Skip to content

Conversation

thiagohirata
Copy link
Contributor

Fixes gh-10564

@pivotal-issuemaster
Copy link

@thiagohirata Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@thiagohirata Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 9, 2017
@philwebb philwebb added priority: normal type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 9, 2017
@philwebb philwebb self-assigned this Oct 9, 2017
@philwebb philwebb added this to the 2.0.0.M5 milestone Oct 9, 2017
@philwebb
Copy link
Member

philwebb commented Oct 9, 2017

Thanks!

@bai-jie
Copy link

bai-jie commented Oct 10, 2017

Note that the default charset of properties file in JDK 9 is UTF-8.

see

@philwebb
Copy link
Member

@bai-jie Thanks for the info. It looks to me like that change may be limited to ResourceBundle handling or properties files. I think Properties.load still uses ISO 8859-1.

@bai-jie
Copy link

bai-jie commented Oct 10, 2017

@philwebb Yes, you are right. Sorry for my misunderstanding.

@philwebb philwebb closed this in 85e71f2 Oct 10, 2017
philwebb added a commit that referenced this pull request Oct 10, 2017
* pr/10565:
  Update OriginTrackedPropertiesLoader to ISO 8859-1
@philwebb
Copy link
Member

@thiagohirata Thanks for the contribution! This has now been merged into master (with a few minor formatting changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.properties loaded using system default encoding, instead of ISO 8859-1
5 participants