GitProperties, BuildProperties support encoding.

[hengyunabc]

No description provided.

[hengyunabc]

@wilkinsona

#10748

[wilkinsona]

Please see #10748 for background. This revised proposal seems like a good compromise to me. Unlike the encoding for application.properties, we can be sure that any configuration setting for the encoding of Git properties or build properties has been read before trying to read the properties file.

[snicoll]

Do the plugins control how the properties file is encoded? For sure build.properties is written with ISO-9959-1 encoding. I haven't seen a property for the git plugin.

[wilkinsona]

Good question, @snicoll. @hengyunabc How are you configuring your build to write UTF-8 characters to the properties files?

[hengyunabc]

@snicoll @wilkinsona

https://github.com/ktoso/maven-git-commit-id-plugin/blob/v2.2.3/src/main/java/pl/project13/maven/git/GitCommitIdMojo.java#L319

My project project.build.sourceEncoding is utf-8.

The content in git.properties:

git.commit.user.name=中文

[snicoll]

@hengyunabc thanks, that's quite interesting. I guess we should do the same thing. That doesn't help Gradle users though.

[wilkinsona]

The equivalent Gradle plugin always uses UTF-8.

[snicoll]

@hengyunabc thanks for your contribution, I've merged it with a polish commit