Add JvmThreadMetrics and JvmGcMetrics binders #11425
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nurkiewicz Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@nurkiewicz Thank you for signing the Contributor License Agreement! |
snicoll
changed the title
snicoll
added
priority: normal
type: enhancement
|
@nurkiewicz thanks for the PR. I went ahead and fixed that in 81af02f instead. Such change is a bit more involved and shouldn't be done in the github interface ideally (documentation and configuration keys have to updated as well). I went ahead and use the same key for the 3 jvm meters since they are highly related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Micrometer 1.0.0.rc5 containt two more binders for JVM:
JvmThreadMetricsandJvmGcMetrics. I believe it's worth having them out-of-the-box.