Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JvmThreadMetrics and JvmGcMetrics binders #11425

Closed
wants to merge 1 commit into from

Conversation

@nurkiewicz
Copy link

commented Dec 25, 2017

Micrometer 1.0.0.rc5 containt two more binders for JVM: JvmThreadMetrics and JvmGcMetrics. I believe it's worth having them out-of-the-box.

@pivotal-issuemaster

This comment has been minimized.

Copy link

commented Dec 25, 2017

@nurkiewicz Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster

This comment has been minimized.

Copy link

commented Dec 25, 2017

@nurkiewicz Thank you for signing the Contributor License Agreement!

@snicoll snicoll changed the title Adding JvmThreadMetrics and JvmGcMetrics binders for micrometer Add JvmThreadMetrics and JvmGcMetrics binders Dec 28, 2017

@snicoll snicoll self-assigned this Dec 28, 2017

@snicoll snicoll added this to the 2.0.0.RC1 milestone Dec 28, 2017

@snicoll snicoll closed this in 81af02f Dec 28, 2017

@snicoll

This comment has been minimized.

Copy link
Member

commented Dec 28, 2017

@nurkiewicz thanks for the PR. I went ahead and fixed that in 81af02f instead. Such change is a bit more involved and shouldn't be done in the github interface ideally (documentation and configuration keys have to updated as well). I went ahead and use the same key for the 3 jvm meters since they are highly related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.