Skip to content

Conversation

sdeleuze
Copy link
Contributor

@sdeleuze sdeleuze commented Aug 6, 2018

See SPR-15092 and SPR-17124.

See SPR-15092 and SPR-17124
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 6, 2018
@wilkinsona
Copy link
Member

It's a little unusual for Boot to manage a dependency that it doesn't use directly. Perhaps we should expand the scope of this a little and provide some auto-configuration for the Jetty RS HTTP client? For example, could WebClientAutoConfiguration configure the builder's connector to be a JettyClientHttpConnector when Jetty's RS HTTP Client is on the classpath. Does that sound reasonable @sdeleuze and @bclozel?

@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 13, 2018
@wilkinsona wilkinsona added this to the Backlog milestone Aug 15, 2018
@bclozel
Copy link
Member

bclozel commented Aug 15, 2018

Also, see SPR-17179 for the Jetty client connector setup.

@sdeleuze
Copy link
Contributor Author

@wilkinsona Yes that's reasonable, and Spring Boot could also leverage JettyResourceFactory I have introduced as part of SPR-17179 in order to share resources between Jetty clients and maybe servers.

@bclozel bclozel self-assigned this Aug 16, 2018
@bclozel bclozel changed the title Manage dependency for Jetty RS HTTP client Support Jetty RS HTTP client as a WebClient connector Aug 22, 2018
@bclozel bclozel modified the milestones: Backlog, 2.1.0.M3 Aug 23, 2018
bclozel pushed a commit that referenced this pull request Aug 23, 2018
This commit adds the Jetty RS HTTP client to the Spring Boot
dependency management. As of SPR-15092 and SPR-17124, this HTTP
client library is supported by Spring Framework.

This commit is first step towards supporting that library as
a driver for the WebClient / ClientHttpConnector auto-configuration.

See gh-14005
@bclozel bclozel closed this in 53f3982 Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants