Remove @UsesUnsafeJava annotations #14072
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
approved these changes
Aug 15, 2018
snicoll
added a commit
that referenced
this pull request
Aug 15, 2018
…tions * pr/14072: Remove @UsesUnsafeJava annotations
|
Reopening because I think we should do this only on master just in case someone happens to be using those annotations. |
|
@philwebb good point, I thought of that as well and decided to go the oversight route and nuke it. Fair enough, I'll restore it in The second copy is package private so I won't restore it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR removes the
@UsesUnsafeJavaannotations that seem to be redundant given that Animal Sniffer was removed and they were introduced for it.Let me know what you think.
Cheers,
Christoph