Make it possible to disable the BackgroundPreinitializer #14298
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the PR. I think we can simplify this by bypassing all initialization if the property is set. The initialization code doesn't actually need to run at all. The reason we currently do it is to kick off in the background so that something called later runs quickly. Probably just returning early from this method if the property is set will be enough. |
philwebb
added
for: merge-with-amendments
snicoll
reviewed
Sep 5, 2018
snicoll
reviewed
Sep 5, 2018
| @@ -69,6 +69,7 @@ content into your application. Rather, pick only the properties that you need. | |||
|
|
|||
| # SPRING CORE | |||
| spring.beaninfo.ignore=true # Whether to skip search of BeanInfo classes. | |||
| spring.backgroundpreinitializer.ignore=true # Whether background preinitializer should be ignored. | |||
There was a problem hiding this comment.
We shouldn't add this here as it's not managed the same way as a regular property. Let's document the property and its usage on the class Javadoc instead.
… into make-possible-disable-backgroundpreinitializer
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Sep 5, 2018
snicoll
added a commit
that referenced
this pull request
Sep 5, 2018
…undpreinitializer * pr/14298: Polish "Make it possible to disable the BackgroundPreinitializer" Make it possible to disable the BackgroundPreinitializer
|
Thanks @ayudovin, this is now merged in |
|
@snicoll, Thank you! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this enhancement