Polish #14667
Polish #14667
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: enhancement
| "description": "Minimum \"Content-Length\" value that is required for compression to be performed.", | ||
| "type": "org.springframework.util.unit.DataSize", | ||
| "defaultValue": "2KB" | ||
| }, |
There was a problem hiding this comment.
Can you share a bit more context why this got removed? I am afraid I had to add it because Compression is in spring-boot and the annotation processor can't read the source description on it.
If you've missed that, you're raising a red flag anyway as we should probably document all properties consistently.
There was a problem hiding this comment.
@snicoll Thanks for the feedback! I just expected that comments on fields in Compression will be harvested for the configuration metadata by the annotation processor. Do I have a wrong expectation?
There was a problem hiding this comment.
Do I have a wrong expectation?
You don't but, unfortunately, it doesn't work that way at the moment.
Compression is in the spring-boot module and it is being used in the spring-boot-autoconfigure module. When the annotation processor runs, it doesn't have access to the source model of Compression (as it's not being compiled in that round). I can see one way to fix that by adding the sources of spring-boot when compiling spring-boot-auto-configure.
In any case, let's raise a separate issue for this and we can take it from there.
There was a problem hiding this comment.
Thanks!
Yes, let's figure this out in #14669 (as manually documenting them may be the outcome of that issue).
snicoll
added
type: task
snicoll
removed
the
status: waiting-for-feedback
* pr/14667: Polish contribution Polish
This PR fixes some typos and polishes trivial stuff.