Add Log Output when DevTools restart is disabled #14807
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
eiselems
commented
Oct 13, 2018
...ools/src/main/java/org/springframework/boot/devtools/restart/RestartApplicationListener.java
Show resolved
Hide resolved
wilkinsona
requested changes
Oct 19, 2018
...ools/src/main/java/org/springframework/boot/devtools/restart/RestartApplicationListener.java
Show resolved
Hide resolved
This covers the cases when: * An Java agent based reloader (e.g. JRebel) is being used * The reloader was disabled by using a system property See gh-14492
|
Update the PR based on the comments |
wilkinsona
added
type: enhancement
wilkinsona
pushed a commit
that referenced
this pull request
Oct 29, 2018
This covers the cases when: * An Java agent based reloader (e.g. JRebel) is being used * The reloader was disabled by using a system property See gh-14807
wilkinsona
added a commit
that referenced
this pull request
Oct 29, 2018
* gh-14807: Polish "Add Log Output when DevTools restart is disabled" Add Log Output when DevTools restart is disabled
|
Thanks for the PR, @eiselems. I've merged the proposed changes into master along with a polish commit that tests the logging in the system property case and restores |
|
Especially thanks for taking your time with the suggested changes/the polish commit and for adding a test case 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the cases when:
See gh-14492