Consider disabling management.trace.http by default #15059
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
… into disabling-management-trace-http-by-default
There was a problem hiding this comment.
Thanks for the PR. Changing this effectively means that the /httptrace endpoint is not active as we won't contribute any repository anymore.
I think the end goal is to make sure that the endpoint react to the presence of a repository implementation. This might bring a unique situation where the endpoint is enabled by default but a property in a separate scope determines whether it can serve content or not.
I've flagged it for team attention so that we discuss this. I've also added a suggestion.
| * @since 2.0.0 | ||
| */ | ||
| @Configuration | ||
| @ConditionalOnWebApplication | ||
| @ConditionalOnProperty(prefix = "management.trace.http", name = "enabled", matchIfMissing = true) | ||
| @ConditionalOnProperty(prefix = "management.trace.http", name = "enabled") |
There was a problem hiding this comment.
That effectively means the default value of this property is now false. This should be reflected in the metadata, the doc and the appendix
snicoll
added
the
for: team-attention
|
@ayudovin thanks fo the PR but that issue wasn't really ready for contributions. As I've indicated in my initial comment, there are more things to consider than just flipping the value of that property. To make that more clear, we've created a new status "pending-design-work". |
snicoll
added
status: declined
this enhancement