Fix StringSequence.equals() for different lengths #15465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
type: bug
snicoll
pushed a commit
that referenced
this pull request
Dec 17, 2018
snicoll
added a commit
that referenced
this pull request
Dec 17, 2018
* pr/15465: Polish "Fix StringSequence.equals() for different lengths" Fix StringSequence.equals() for different lengths
|
Good catch, thanks again Christoph. This is now merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
while working on an optimization in
StringSequence.subSequence()I noticed thatStringSequence.equals()returnstruefor sequences with different lengths. In order to be able to easily cherry-pick that here is the isolated PR just for the fix without the optimization (on which I'd ask for feedback later in a separate PR).Cheers,
Christoph