Use AssertJ facilities for expected exceptions #16066
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks @dreis2211. They might have been missed in #16066. |
mbhave
added
type: task
|
Oops, sorry I did mean that. I don't know why I pasted the same issue number 🤦♀️ |
|
Test failure seems unrelated. |
snicoll
approved these changes
Mar 4, 2019
snicoll
pushed a commit
that referenced
this pull request
Mar 4, 2019
snicoll
added a commit
that referenced
this pull request
Mar 4, 2019
* pr/16066: Polish "Use AssertJ facilities for expected exceptions" Use AssertJ facilities for expected exceptions
|
@dreis2211 good catch again, thanks. |
|
Sorry I missed the 3 copyright updates :/ |
|
No need to be sorry, Christoph. Thanks for all the hard work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just noticed some usages of
@Test(expected = SomeException.class)that could probably benefit from using AssertJ facilities. E.g. by making clear what is expected to fail in a test.Let me know what you think.
Cheers,
Christoph