Support zip64 jars #16091
Closed
Support zip64 jars #16091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
cvienot
force-pushed
the
support-for-zip64-jars
branch
2 times, most recently
from
9535b06 to
2fb1808
Compare
washingtonsoares
approved these changes
Mar 15, 2019
johnhunt
approved these changes
Mar 18, 2019
| if (isZip64()) { | ||
| return this.zip64End.get().getNumberOfRecords(); | ||
| } | ||
| else { |
There was a problem hiding this comment.
Because of the return, you don't need an else {} statement
| if (isZip64()) { | ||
| return this.zip64End.get().getCentratDirectory(data); | ||
| } | ||
| else { |
There was a problem hiding this comment.
Because of the return, you don't need an else {} statement
ilya123s
reviewed
Mar 21, 2019
| } | ||
|
|
||
| @Test | ||
| public void zip64ArchivesAreHandledGracefully() throws IOException { |
There was a problem hiding this comment.
This test name case should be renamed as it's not longer checking for an exception
ilya123s
approved these changes
Mar 21, 2019
| } | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
This test name case should be renamed as it's not longer checking for an exception
cvienot
force-pushed
the
support-for-zip64-jars
branch
from
2fb1808 to
59bf72a
Compare
philwebb
added
the
for: team-attention
# Conflicts: # spring-boot-project/spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/jar/CentralDirectoryEndRecord.java
philwebb
added
type: enhancement
wilkinsona
pushed a commit
that referenced
this pull request
Sep 20, 2019
wilkinsona
added a commit
that referenced
this pull request
Sep 20, 2019
|
Thanks very much for the PR, @cvienot. Zip64 was one of our oldest outstanding feature requests so it's great to finally have support for it. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-2895
Add support for zip64 jars by parsing zip64 specific records, to read correct number of files, offsets and sizes