Skip to content

Check for multiple processors in OnClassCondition #16115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Check for multiple processors in OnClassCondition #16115

wants to merge 2 commits into from

Conversation

JWThewes
Copy link
Contributor

@JWThewes JWThewes commented Mar 6, 2019

This is my first commit so any help or guidance is welcome.
I've implemented the Runtime.getRuntime().availableProcessors() > 1 check and added a case when the processor count is equal 1.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 6, 2019
@wilkinsona wilkinsona mentioned this pull request Mar 8, 2019
Closed
@wilkinsona wilkinsona changed the title Check for multiple processors in OnClassCondition #16105 Check for multiple processors in OnClassCondition Mar 8, 2019
@wilkinsona wilkinsona added this to the 2.2.x milestone Mar 8, 2019
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 8, 2019
@JWThewes
Copy link
Contributor Author

JWThewes commented Mar 8, 2019

So as this was my first PR I assume that it was ok? Would be great to get some sort of feedback I can apply when creating other PRs.

Kind regards
Jan

@snicoll
Copy link
Member

snicoll commented Mar 8, 2019

@JWThewes PR are reviewed and merged accordingly. We'll make sure to provide feedback in due course.

@snicoll snicoll self-assigned this Mar 13, 2019
snicoll pushed a commit that referenced this pull request Mar 13, 2019
@JWThewes @snicoll
Check for multiple processors in OnClassCondition
a96a79e 
See gh-16115
@snicoll snicoll closed this in 4d73211 Mar 13, 2019
snicoll added a commit that referenced this pull request Mar 13, 2019
@snicoll
Merge pull request #16115 from JWThewes
210c51e 
* pr/16115:
  Polish "Check for multiple processors in OnClassCondition"
  Check for multiple processors in OnClassCondition
@snicoll
Copy link
Member

snicoll commented Mar 13, 2019

@JWThewes thank you for the contribution. They were several problems with it that I've fixed in 4d73211.

In the future, please do not create a PR from master as it makes it harder to push additional changes in case the team is asking for changes. Make sure you're up to date and create a branch first. As you can see from the commit tab, this PR has two commits, one of which is unrelated. I've dropped it locally before merging.

As for the code, the single case was still starting a thread unfortunately (see createOutcomesResolver).

@snicoll snicoll modified the milestones: 2.2.x, 2.2.0.M2 Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.2.0.M2
Development

Successfully merging this pull request may close these issues.
4 participants
@JWThewes @snicoll @wilkinsona @spring-projects-issues