AutoConfiguration support for Data Mongo ReactiveGridFsTemplate #16467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
… into autoConfiguration-support-mongo-reactiveGridFsTemplate
|
Test failure seems unrelated |
… into autoConfiguration-support-mongo-reactiveGridFsTemplate
… into autoConfiguration-support-mongo-reactiveGridFsTemplate
mp911de
reviewed
Apr 8, 2019
| public ReactiveGridFsTemplate reactiveGridFsTemplate( | ||
| ReactiveMongoDatabaseFactory reactiveMongoDbFactory, | ||
| MappingMongoConverter mappingMongoConverter) { | ||
| return new ReactiveGridFsTemplate(reactiveMongoDbFactory, mappingMongoConverter); |
There was a problem hiding this comment.
Ideally, we should configure ReactiveGridFsTemplate with DataBufferFactory to share potentially resources.
There was a problem hiding this comment.
ReactiveGridFsTemplate constructor has 4 parameters:
-
DataBufferFactory -
ReactiveMongoDatabaseFactory -
MappingMongoConverter -
bucket
What value of bucket should be in this case?
There was a problem hiding this comment.
mbhave
added
type: enhancement
snicoll
requested changes
Apr 17, 2019
| @Test | ||
| public void gridFsTemplateExists() { | ||
| this.contextRunner.run((context) -> assertThat(context) | ||
| .hasSingleBean(ReactiveMongoTemplate.class)); |
There was a problem hiding this comment.
This looks like you're checking for the wrong bean there.
|
|
||
| @Bean | ||
| @ConditionalOnMissingBean | ||
| public DataBufferFactory dataBufferFactory() { |
There was a problem hiding this comment.
Can we flip those two methods? Required dependencies are defined before so I'd like to keep it that way.
snicoll
added
the
status: waiting-for-feedback
snicoll
removed
the
status: waiting-for-feedback
snicoll
pushed a commit
that referenced
this pull request
Apr 17, 2019
snicoll
added a commit
that referenced
this pull request
Apr 17, 2019
* pr/16467: Polish "Add auto-configuration support for ReactiveGridFsTemplate" Add auto-configuration support for ReactiveGridFsTemplate
|
@ayudovin thanks for the feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this enhancement