Flyway and Liquibase auto-configuration does not consider DataSource properties configured via @AutoConfigureTestDatabase #16814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deakandris Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@deakandris Thank you for signing the Contributor License Agreement! |
Both Flyway and Liquibase makes use of DataSourceProperties to get default properties. However both uses strictly the configuration properties and fail to consider embedded datasource properties autoconfigured by @AutoConfigureTestDatabase. In case a database layer test e.g. @jdbcTest relies on the autoconfigured embedded datasource, Flyway and Liquibase autoconfiguration fails as they are not aware of the embedded datasource properties.
|
I have no idea why |
philwebb
added
type: bug
wilkinsona
changed the title
wilkinsona
pushed a commit
that referenced
this pull request
Jun 17, 2019
Both Flyway and Liquibase makes use of DataSourceProperties to get default properties. Previously, both used strictly the configuration properties and failed to consider embedded datasource properties autoconfigured by @AutoConfigureTestDatabase. In case a database layer test e.g. @jdbcTest relies on the autoconfigured embedded datasource, Flyway and Liquibase autoconfiguration fails as they are not aware of the embedded datasource properties. See gh-16814
wilkinsona
added a commit
that referenced
this pull request
Jun 17, 2019
|
Thank you very much for making your first contribution to Spring Boot, @deakandris. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Flyway and Liquibase makes use of
DataSourcePropertiesto get default properties.However both uses strictly the configuration properties and fail to consider
embedded datasource properties autoconfigured by
@AutoConfigureTestDatabase.In case a database layer test e.g.
@JdbcTestrelies on the autoconfiguredembedded datasource, Flyway and Liquibase autoconfiguration fails
as they are not aware of the embedded datasource properties.