Skip to content

Reactive health indicators do not log health check failure #17635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Reactive health indicators do not log health check failure #17635

wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Jul 25, 2019

see gh-17634

@nosan
Copy link
Contributor Author

nosan commented Jul 25, 2019

oops, @since tag is wrong :(

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 25, 2019
@nosan nosan changed the title Update Reactive health indicators to log errors. Update Reactive health indicators to log health check failure Jul 25, 2019
@snicoll snicoll mentioned this pull request Jul 29, 2019
Closed
@snicoll snicoll self-assigned this Jul 29, 2019
@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 29, 2019
@snicoll snicoll added this to the 2.1.7 milestone Jul 29, 2019
@snicoll snicoll changed the title Update Reactive health indicators to log health check failure Reactive health indicators do not log health check failure Jul 29, 2019
snicoll pushed a commit that referenced this pull request Jul 29, 2019
@nosan @snicoll
Log health check failure with Reactive health indicators
fe1b9c9 
See gh-17635
snicoll added a commit that referenced this pull request Jul 29, 2019
@snicoll
Polish "Log health check failure with Reactive health indicators"
6356852 
See gh-17635
@snicoll snicoll mentioned this pull request Jul 29, 2019
Closed
@snicoll snicoll closed this in c99f201 Jul 29, 2019
@snicoll
Copy link
Member

snicoll commented Jul 29, 2019

Thanks once again, @nosan.

@nosan
Copy link
Contributor Author

nosan commented Jul 29, 2019

Thanks, @snicoll

@nosan nosan deleted the gh-17634 branch January 28, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: bug A general bug
Projects
None yet
Milestone
2.1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@nosan @snicoll @spring-projects-issues