Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax errors in docs #17835

Closed

Conversation

@dreis2211
Copy link
Contributor

commented Aug 11, 2019

Hi,

this PR fixes two syntax errors in code examples inside the docs.

Cheers,
Christoph

snicoll added a commit that referenced this pull request Aug 12, 2019
@snicoll snicoll self-assigned this Aug 12, 2019
@snicoll snicoll added this to the 2.2.0.M6 milestone Aug 12, 2019
@snicoll snicoll closed this in 0bdf2b8 Aug 12, 2019
@snicoll

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Let's review the containsString change as we should probably use something else now anyway.

@snicoll snicoll reopened this Aug 12, 2019
@snicoll snicoll modified the milestones: 2.2.0.M6, 2.1.8 Aug 12, 2019
@snicoll snicoll closed this in 56c2a52 Aug 12, 2019
@dreis2211

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

Which containsString?

@snicoll

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Ah! I am the one introducing the problem when I backported your change in 2.1.x 😑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.