Remove management.health.status.order from docs #18170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: documentation
|
@philwebb I just noticed another slightly related doc error related to this. Give me a minute to fix this. |
|
Sure thing! I'm just triaging issues at the moment, not merging. |
|
Done. |
snicoll
reviewed
Sep 9, 2019
| @@ -162,7 +171,10 @@ | |||
| "OUT_OF_SERVICE", | |||
| "UP", | |||
| "UNKNOWN" | |||
| ] | |||
| ], | |||
There was a problem hiding this comment.
This shouldn't be required as the annotation processor is supposed to pick things up. I've opened #18184
There was a problem hiding this comment.
The issue is fixed so I'll rebase and polish this part.
snicoll
pushed a commit
that referenced
this pull request
Sep 9, 2019
snicoll
pushed a commit
that referenced
this pull request
Sep 9, 2019
snicoll
added a commit
that referenced
this pull request
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
while working on another PR I noticed that
management.health.status.orderis still showing in the Actuator Properties section of the docs, although it should be deprecated.This PR also fixes
management.endpoint.health.status.http-mapping.*not showing up at all as a side-effect.Let me know what you think. I found it quite "unintuitive" - maybe that's the word I'm looking for - to work with the metadata stuff and I'm not sure if this should be solved differently or if there is a convention for the metadata.json files.
Cheers,
Christoph