Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-defined logging group documentation #18270

Closed
wants to merge 1 commit into from
Closed

Fix pre-defined logging group documentation #18270

wants to merge 1 commit into from

Conversation

AlexFalappa
Copy link
Contributor

In the documentation at https://docs.spring.io/spring-boot/docs/2.2.0.BUILD-SNAPSHOT/reference/html/spring-boot-features.html#boot-features-custom-log-groups the table describing loggers belonging to the pre-defined logging groups had a duplicated row for the sql group.

I have also added missing loggers to the web group (list taken from org.springframework.boot.context.logging.LoggingApplicationListener source)

In the documentation at https://docs.spring.io/spring-boot/docs/2.2.0.BUILD-SNAPSHOT/reference/html/spring-boot-features.html#boot-features-custom-log-groups the table describing loggers belonging to the pre-defined logging groups had a duplicated row for the _sql_ group.

I have also added missing loggers to the _web_ group (list taken from `org.springframework.boot.context.logging.LoggingApplicationListener` source)
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 18, 2019
@mbhave mbhave added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 19, 2019
@mbhave mbhave added this to the 2.1.x milestone Sep 19, 2019
@snicoll snicoll changed the title Fix pre-defined logging group composition Fix pre-defined logging group documentation Sep 19, 2019
@snicoll
Copy link
Member

snicoll commented Sep 19, 2019

In 2.1.x we're missing the web ones, but the SQL one is new so I'll backport the former only

snicoll pushed a commit that referenced this pull request Sep 19, 2019
@snicoll snicoll closed this in 9c9833f Sep 19, 2019
@snicoll snicoll self-assigned this Sep 19, 2019
@snicoll snicoll modified the milestones: 2.1.x, 2.1.9 Sep 19, 2019
@AlexFalappa AlexFalappa deleted the patch-1 branch September 20, 2019 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants