-
Notifications
You must be signed in to change notification settings - Fork 41.5k
Support amqps:// URIs in spring.rabbitmq.addresses #18808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@markpollack thank you for performing this PR this is something that I have had on my list of things to contribute for some time. I know other in the community will greatly benefit from this update. 🎉 |
...utoconfigure/src/main/java/org/springframework/boot/autoconfigure/amqp/RabbitProperties.java
Outdated
Show resolved
Hide resolved
…g/springframework/boot/autoconfigure/amqp/RabbitProperties.java Co-Authored-By: Bryan Kelly <xyloman@gmail.com>
There's some room for improvement here where if an |
Good catch. I suppose we'd need to check that all adresses are either all using |
See spring-projectsgh-18808 Co-Authored-By: Bryan Kelly <xyloman@gmail.com>
I think we should determine whether or not to implicitly enable SSL based on the first address. This will align the behaviour with determining the host, port, etc that are set on the |
See spring-projectsgh-18808 Co-Authored-By: Bryan Kelly <xyloman@gmail.com>
See gh-18808 Co-Authored-By: Bryan Kelly <xyloman@gmail.com>
Thank you Mark. As suggested by @mbhave, I've polished your proposal to automatically enable ssl support when |
If
ampqs
is used in the URI and no explicit port is declared, the port number 5671 will be used instead of 5672Resolves #6401