Dependency management has unnecessary log4j exclusion for spring-cloud-spring-service-connector #18833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... spring-cloud-spring-service-connector. The dependency on `log4j:log4j` appears to have been removed from spring-cloud-spring-service-connector in late 2014 as part of [spring-cloud-connectors issue spring-projects#96](spring-cloud/spring-cloud-connectors#96), in commit [f2be5e94305446d4698636a9037bf44185f418ed](spring-cloud/spring-cloud-connectors@f2be5e9) (2014-11-24), and was included beginning with spring-cloud-connectors `v1.1.1.RELEASE` I did a quick example app using spring-cloud-connectors-service-connector `2.0.6.RELEASE` and do not see `log4j:log4j`. _...and now I see that [Spring Cloud Connectors](https://github.com/spring-cloud/spring-cloud-connectors) is_ > is in maintenance mode, in favor of the newer Java CFEnv project _...so perhaps this is moot._
spring-projects-issues
added
the
status: waiting-for-triage
|
@larrywest Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@larrywest Thank you for signing the Contributor License Agreement! |
|
Thanks for the PR. Yes, this has been deprecated in |
snicoll
changed the title
snicoll
added
type: bug
snicoll
pushed a commit
that referenced
this pull request
Nov 1, 2019
|
@larrywest yep, worth removing unnecessary lines in there indeed. Thank you for making your first contribution to Spring Boot. |
|
(@snicoll FYI, your comment sounds like you intended to merge the PR, but it is "closed with unmerged commits".) |
|
That's a GitHub bug that you may want to report to them. Here's your commit in the master branch: 82a41a3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... spring-cloud-spring-service-connector.
The dependency on
log4j:log4jappears to have been removed from spring-cloud-spring-service-connector in late 2014 as part of spring-cloud-connectors issue #96, in commit f2be5e94305446d4698636a9037bf44185f418ed (2014-11-24), which was included beginning with spring-cloud-connectorsv1.1.1.RELEASE.I did a quick example app using spring-cloud-spring-service-connector
2.0.6.RELEASEand do not seelog4j:log4j....and now I see that Spring Cloud Connectors is
...so perhaps this is moot. Or perhaps it's worth removing six unneeded lines from this file.